[HOLD for payment 2024-01-25] [$125] Add a new download success message specifically for Settings > Share code > Download

[jamesdeanexpensify]

Summary

I believe the code is here for this. I don't think we should change the existing fileDownload success message because it might end up being used elsewhere as a generic success message and, more importantly, we want to create a specific message for this scenario.

So this is what should happen:

1. In the New Expensify mobile app, go to Settings > Share code > tap Download
2. The modal that pops up (if successful) should say something like:

• Downloaded!
• Attachment successfully downloaded! (this is on iOS, at least)

3. We'd like to update it to say:

• Downloaded!
• Check your photos or downloads folder for a copy of your QR code. Protip: Add it to a presentation for your audience to scan and connect with you directly.

[Slack thread, for internal reference]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01915b215ea2a7921b
• Upwork Job ID: 1742674427176837120
• Last Price Increase: 2024-01-04
• Automatic offers:
• abzokhattab | Contributor | 28089531

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01915b215ea2a7921b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add a new download success message specifically for Settings > Share code > Download

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

the following showSuccessAlert function should take the translations as optional fields and if they are not provided then it will display the default translation:

App/src/libs/fileDownload/FileUtils.ts

Lines 11 to 23 in 1b58d05

	function showSuccessAlert() {
	Alert.alert(
	Localize.translateLocal('fileDownload.success.title'),
	Localize.translateLocal('fileDownload.success.message'),
	[
	{
	text: Localize.translateLocal('common.ok'),
	style: 'cancel',
	},
	],
	{cancelable: false},
	);
	}

then we need to add these params in android and in ios

then going up the translation should be passed to the file download function

and call it here :

App/src/components/QRShare/QRShareWithDownload/index.js

Line 25 in c6208fe

svg.toDataURL((dataURL) => resolve(fileDownload(dataURL, getQrCodeFileName(this.props.title))));

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add a new download success message specifically for Settings > Share code > Download

What is the root cause of that problem?

New Feature




What changes do you think we should make in order to solve the problem?

We will need a new alert as the default one has the file Download text hardcoded.



We can:

• Add a new QRSuccessAlert function that shows our new custom text. We can trigger this alert by using an optional prop isQRDownload

Implementation:

• We will add the new copy to language files under filedownload.qr key.
• We will define a new function in FileUtils.ts:

  • function showQRSuccessAlert() {
        Alert.alert(
            Localize.translateLocal('fileDownload.qr.success.title'),
            Localize.translateLocal('fileDownload.qr.success.message'),
            [
                {
                    text: Localize.translateLocal('common.ok'),
                    style: 'cancel',
                },
            ],
            {cancelable: false},
        );
    }

• This function will be called when we show the success alert based on if the isQRDownload prop was passed

Alternatively:



- 
Modify the fileDownload function to take in custom alert text props, which we will pass to the successAlert function here


[samsonmobisa]

function showSuccessAlert() {
const successMessage = Check your photos or downloads folder for a copy of your QR code. Protip: Add it to a presentation for your audience to scan and connect with you directly.;

Alert.alert(
    Localize.translateLocal('fileDownload.success.title'),
    Localize.translateLocal('fileDownload.success.message'),
    [
        {
            text: Localize.translateLocal('common.ok'),
            style: 'cancel',
        },
    ],
    { cancelable: false, message: successMessage }
);

}

[melvin-bot]

📣 @samsonmobisa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[samsonmobisa]

function showSuccessAlert() {
const successMessage = Check your photos or downloads folder for a copy of your QR code. Protip: Add it to a presentation for your audience to scan and connect with you directly.;

Alert.alert(
    Localize.translateLocal('fileDownload.success.title'),
    Localize.translateLocal('fileDownload.success.message'),
    [
        {
            text: Localize.translateLocal('common.ok'),
            style: 'cancel',
        },
    ],
    { cancelable: false, message: successMessage }
);

}

[samsonmobisa]

Contributor details
Your Expensify account email: samsonmobisa62@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/samsonmobisa

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[samsonmobisa]

Contributor details
Your Expensify account email: samsonmobisa62@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~018e78ebb343f52495