[HOLD for payment 2024-01-11] [HOLD for payment 2024-01-09] [$500] IOU - When adding a receipt to a manual IOU, the error "Receipt missing details" appears

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.20-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Open New Expensify app
Log in with any account
Click on FAB > Request Money > Manual
Input an amount and click Next
Enter/select an option for the request
Click on the three-dot menu at the top right
Click on "Add Receipt"
Click on "Choose File" and Select an image
Complete the request

Expected Result:

No error should appear when adding a receipt to a manual IOU

Actual Result:

When adding a receipt to a manual IOU, the error "Receipt missing details" appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6328742_1703884402000.Recording__1008.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014720a73c52b8fa9d
Upwork Job ID: 1740860349188747264
Last Price Increase: 2023-12-29
Automatic offers:

paultsimura | Contributor | 28077743
situchan | Contributor | 28080992

Issue Owner

Current Issue Owner: @CortneyOfstad

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@joelbettner

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~014720a73c52b8fa9d

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@situchan

@situchan @waterim I think this might be happening because of this PR, but I'm not entirely sure.

@mountiny

cc: @mountiny

Yeah Someone can try to reproduce, then revert on main and repro again to confirm, I am fixing some issues and we we have weekend to resolve, its been quite complicated Pr so ideally we fix this instead of reverting

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Make merchant required only on Expense reports #33850

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue — @paultsimura paid $250 via Upwork; @Tony-MK paid $250 via Upwork
Contributor+ that helped on the issue and/or PR — @situchan paid $500 via Upwork

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Contributor)
@situchan requires payment automatic offer (Contributor)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@mountiny

Hey everyone,

Advice by @mountiny, this comment is a continuation of this slack discussion.

Below are the PR changes meant the fix this issue from his Proposal.

App/src/libs/TransactionUtils.ts

Lines 33 to 38 in ff95c0c

    
           let allReports: OnyxCollection<Report>; 
        
           Onyx.connect({ 
        
               key: ONYXKEYS.COLLECTION.REPORT, 
        
               waitForCollectionCallback: true, 
        
               callback: (value) => (allReports = value), 
        
           });

App/src/libs/TransactionUtils.ts

Lines 159 to 161 in ff95c0c

    
           const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`] ?? null; 
        
           const isFromExpenseReport = parentReport?.type === CONST.REPORT.TYPE.EXPENSE; 
        
           return (isFromExpenseReport && isMerchantMissing(transaction)) || isAmountMissing(transaction) || isCreatedMissing(transaction);

Also, here are the suggestions for my proposal's alternative solution A presented.

What alternative solutions did you explore? (Optional)

Option A Just like in IOU.js, TaskUtil.ts, ReportUtils.ts, and many others, we can connect to the onyx and get only parent reports from ONYXKEYS.COLLECTION.REPORT. Then, store them in an array in TransactionUtils.js like such: let allReports: OnyxCollection<Report>.

The last action for both options A and B will be checking if is an expense report with parentReport?.type === CONST.REPORT.TYPE.EXPENSE.

@CortneyOfstad

Note for @CortneyOfstad I think @paultsimura did not do this intentionally but in Slack mentioned he is happy to split the reward for fairness. In that case we can pay $250 each for @paultsimura and @Tony-MK

$500 to @situchan

@Tony-MK

@Tony-MK sent you a proposal — please let me know once you accept so I can get that paid to you 👍

@paultsimura — paid you $250 per the comment above via Upwork

@situchan — paid you $500 via Upwork

@CortneyOfstad

Thanks, @CortneyOfstad . I accepted the offer.

@paultsimura

Paid!

Payment Summary

Contributor that fixed the issue — @paultsimura paid $250 via Upwork; @Tony-MK paid $250 via Upwork
Contributor+ that helped on the issue and/or PR — @situchan paid $500 via Upwork

@situchan

@situchan any updates on the checklist above? TIA!

The PR that introduced the bug has been identified. Link to the PR: Feature: Update merchant to be empty and with validation #32486 (comment)
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Feature: Update merchant to be empty and with validation #32486
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was deploy blocker. Caught during regression testing so no need another one.

Perfect! Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-11] [HOLD for payment 2024-01-09] [$500] IOU - When adding a receipt to a manual IOU, the error "Receipt missing details" appears #33786

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

53 remaining items

What alternative solutions did you explore? (Optional)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	let allReports: OnyxCollection<Report>;
	Onyx.connect({
	key: ONYXKEYS.COLLECTION.REPORT,
	waitForCollectionCallback: true,
	callback: (value) => (allReports = value),
	});

	const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`] ?? null;
	const isFromExpenseReport = parentReport?.type === CONST.REPORT.TYPE.EXPENSE;
	return (isFromExpenseReport && isMerchantMissing(transaction)) \|\| isAmountMissing(transaction) \|\| isCreatedMissing(transaction);

[HOLD for payment 2024-01-11] [HOLD for payment 2024-01-09] [$500] IOU - When adding a receipt to a manual IOU, the error "Receipt missing details" appears #33786

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Dec 29, 2023

melvin-bot commented on Dec 29, 2023

melvin-bot commented on Dec 29, 2023

melvin-bot commented on Dec 29, 2023

joelbettner commented on Dec 29, 2023

situchan commented on Dec 29, 2023

mountiny commented on Dec 29, 2023

53 remaining items

melvin-bot commented on Jan 4, 2024

melvin-bot commented on Jan 4, 2024

Tony-MK commented on Jan 9, 2024

What alternative solutions did you explore? (Optional)

mountiny commented on Jan 9, 2024

CortneyOfstad commented on Jan 11, 2024

Tony-MK commented on Jan 11, 2024

CortneyOfstad commented on Jan 11, 2024

Payment Summary

CortneyOfstad commented on Jan 11, 2024

situchan commented on Jan 11, 2024

CortneyOfstad commented on Jan 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions