[$500] IOU - IOU preview loading skeleton displays in room chat when user requested money and relogin

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.19.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open app
2. Create a Workspace
3. Add a few members
4. Open announce room of the workspace
5. Make a split bill with all members
6. Sign Out
7. Sign In with the same account
8. Navigate to announce room

Expected Result:

IOU preview should be displayed with amount

Actual Result:

IOU preview loading skeleton displays in room chat when user requested money and relogin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6328556_1703870235441.Rpreplay_Final1703869667.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019428618ac31844be
• Upwork Job ID: 1740790325272899584
• Last Price Increase: 2024-01-05
• Automatic offers:
• paultsimura | Contributor | 28090718

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019428618ac31844be

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report preview is not properly loaded after relogin.

What is the root cause of that problem?

It's a result of the memory load-reducing changes that were introduced recently: we don't load the IOU report data from the BE when opening a chat report: #32658 (comment)

Therefore, the transaction data is not present in Onyx until we open the IOU report itself.

What changes do you think we should make in order to solve the problem?

According to #32658 (comment), we should use the data stored in a report action itself to display the IOU report preview. Therefore, we should use the data from props.action (mostly from the props.action.originalMessage to build the data on MoneyRequestPreview if the props.transaction is missing (we can make it a separate function ReportActionsUtils.getOriginalTransactionDetails:

{
    amount: lodashGet(props.action, 'originalMessage.amount', 0),
    currency: lodashGet(props.action, 'originalMessage.currency', ''),
    comment: lodashGet(props.action, 'originalMessage.comment', ''),
    merchant: lodashGet(props.action, 'originalMessage.merchant', ''),
}

This will make sure we show most of the data while the transaction is not loaded explicitly:

We might also want to coordinate with BE to add extra details to the action.originalMessage, like the merchant (currently it's present only in the transaction).

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU preview loading skeleton displays in room chat when user requested money and relogin

What is the root cause of that problem?

After logout and login again, the OpenReport API doesn't return transaction data and the IOU report. So the App display loading skeleton because this logic

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 273 to 278 in 2fe1174

	{_.isEmpty(props.transaction) &&
	!ReportActionsUtils.isMessageDeleted(props.action) &&
	lodashGet(props.action, 'pendingAction') !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? (
	<MoneyRequestSkeletonView />
	) : (
	<View style={styles.moneyRequestPreviewBoxText}>

What changes do you think we should make in order to solve the problem?

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 273 to 278 in 2fe1174

	{_.isEmpty(props.transaction) &&
	!ReportActionsUtils.isMessageDeleted(props.action) &&
	lodashGet(props.action, 'pendingAction') !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? (
	<MoneyRequestSkeletonView />
	) : (
	<View style={styles.moneyRequestPreviewBoxText}>

I suggest we should remove this logic

And then in here

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 154 in 27a51a4

const {amount: requestAmount, currency: requestCurrency, comment: requestComment, merchant: requestMerchant} = ReportUtils.getTransactionDetails(props.transaction);

we should update logic to use information from action when transaction is empty like this

const {amount: requestAmount, currency: requestCurrency, comment: requestComment, merchant: requestMerchant} = 
            !_.isEmpty(props.transaction) ? ReportUtils.getTransactionDetails(props.transaction) :  {
                amount: lodashGet(props.action, 'originalMessage.amount', 0),
                currency: lodashGet(props.action, 'originalMessage.currency', ''),
                comment: lodashGet(props.action, 'originalMessage.comment', ''),
                merchant: lodashGet(props.action, 'originalMessage.merchant', '')
            };

We also can create a utils function to return transaction details from reportActions

What alternative solutions did you explore? (Optional)

NA