[HOLD for payment 2024-03-07] [$500] Web- Split - Tooltip shows email instead of display name when hovering over counter in split preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.19-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Split bill with at least 5 people with display name
2. Hover over counter on the split preview

Expected Result:

The tooltip shows the display name for participants that have a display name

Actual Result:

The tooltip shows the contact details of the participants

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6328028_1703813445736.20231229_084143.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194c00ce94ea69983
• Upwork Job ID: 1740550740664324096
• Last Price Increase: 2024-01-05
• Automatic offers:
• dukenv0307 | Contributor | 28091548

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0194c00ce94ea69983

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

The compose box displays duplicate characters upon pressing a single key

What is the root cause of that problem?

The root cause is that we shows the logins not full name ,FirstName and lastName, when we create icons data here.

App/src/libs/OptionsListUtils.js

Lines 134 to 150 in 595bf40

	function getAvatarsForAccountIDs(accountIDs, personalDetails, defaultValues = {}) {
	const reversedDefaultValues = {};
	_.map(Object.entries(defaultValues), (item) => {
	reversedDefaultValues[item[1]] = item[0];
	});
	return _.map(accountIDs, (accountID) => {
	const login = lodashGet(reversedDefaultValues, accountID, '');
	const userPersonalDetail = lodashGet(personalDetails, accountID, {login, accountID, avatar: ''});
	return {
	id: accountID,
	source: UserUtils.getAvatar(userPersonalDetail.avatar, userPersonalDetail.accountID),
	type: CONST.ICON_TYPE_AVATAR,
	name: userPersonalDetail.login,
	};
	});

App/src/components/MultipleAvatars.tsx

Line 108 in 595bf40

const tooltipTexts = useMemo(() => (shouldShowTooltip ? icons.map((icon) => icon.name) : ['']), [shouldShowTooltip, icons]);

What changes do you think we should make in order to solve the problem?

We need to update this part to show full name here

function getAvatarsForAccountIDs(accountIDs, personalDetails, defaultValues = {}) {
    const reversedDefaultValues = {};
    _.map(Object.entries(defaultValues), (item) => {
        reversedDefaultValues[item[1]] = item[0];
    });

    return _.map(accountIDs, (accountID) => {
        const login = lodashGet(reversedDefaultValues, accountID, '');
        const userPersonalDetail = lodashGet(personalDetails, accountID, {login, accountID, firstName, lastName, avatar: ''});

        return {
            id: accountID,
            source: UserUtils.getAvatar(userPersonalDetail.avatar, userPersonalDetail.accountID),
            type: CONST.ICON_TYPE_AVATAR,
            name: userPersonalDetail.firstName || userPersonalDetail.lastName ? `${userPersonalDetail.firstName ?? ''} ${userPersonalDetail.lastName ?? ''}` : userPersonalDetail.login,
        };
    });
}

screen-capture.3.webm

What alternative solutions did you explore? (Optional)

 name: ReportUtils.getDisplayNameForParticipant(accountId)

We can use getDisplayNameForParticipant instead of setting full name manually here.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip shows the contact details of the participants

What is the root cause of that problem?

In here, we're not retrieving the proper name to display for the user, we're only using the login.

What changes do you think we should make in order to solve the problem?

We should use getDisplayNameForParticipant here to get the display name, it already handles all the cases we need.

name: ReportUtils.getDisplayNameForParticipant(accountID)

The cases are:

• Optimistic personal detail
• Hidden
• Long name (which uses the personalDetails.displayName)
  ...
  All are handled in that method and the method is already used everywhere we want to get the user display name as well, so we can just use that here.

We can adjust the shouldUseShortForm, shouldFallbackToHidden of that method depending on design opinion, but I think the default values are good enough for us in this case.

Additionally, we should make sure to use the same code when displaying the tooltip on Avatar and when displaying the concatenated text for extra users, by creating an util like getUserDetailsTooltipText that will accept a list of accountIDs, and return the list of tooltip text based on the those accountIDs, then we can reuse between the BaseUserDetailsTooltip and the concatenated tooltips that we have, more detail here.

What alternative solutions did you explore? (Optional)

There might be other places that are still using the login, if there're any other such cases, we can use the same solution

[unidev727]

Proposal updated. Just added an alternative solution.
But it seems good to get full name immediately without calling extra function, I think.

[dukenv0307]

Proposal updated with minor changes for clarity, also just so there's no confusion, it was the first to recommend using getDisplayNameForParticipant