Repository navigation
[HOLD for payment 2024-01-09] [HOLD for payment 2024-01-05] Mweb/Chrome - IOU - Scan page keeps loading infinitely #33732
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.19
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/
- Tap fab
- Tab request money
4.Tap Scan
Expected Result:
Scan page must be displayed properly and it must not load infinitely
Actual Result:
Scan page keeps loading infinitely
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
github-actions commentedon Dec 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ishpaul777 commentedon Dec 29, 2023
#32577 is the offending PR confirmed with revert
test branch - https://github.com/ishpaul777/App/tree/revert-32577-perf/request-money-tabs-animation
marcaaron commentedon Dec 29, 2023
Thanks @ishpaul777. Will wait to see what @mountiny wants to do here.
shubham1206agra commentedon Dec 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Mweb/Chrome - IOU - Scan page keeps loading infinitely
What is the root cause of that problem?
This is happening because we disabled animation here for web platforms https://github.com/Expensify/App/pull/32577/files#r1437995158.
And we use
useTabNavigatorFocusinNavigationAwareCamera, which relies onuseTabAnimation(). Since we have disabled the Navigation, the camera never loads asuseTabAnimation()retuers null (or error), and will makeshouldShowCamerato false always.What changes do you think we should make in order to solve the problem?
Remove
useTabNavigatorFocus, and related code for web platforms as we no longer have animation for that. Do the same for RecieptSelector.Result:
Screen.Recording.2023-12-29.at.11.08.46.AM.mov
What alternative solutions did you explore? (Optional)
We can split
useTabNavigatorFocusfor 2 different platforms web and native, and remove use ofuseTabAnimationin web codeshubham1206agra commentedon Dec 29, 2023
@kacper-mikolajczak Can you check the above proposal ^ ?
mountiny commentedon Dec 29, 2023
Thanks @marcaaron I will take over this blocker as deployer
mountiny commentedon Dec 29, 2023
@kacper-mikolajczak is making the PR
12 remaining items
[-]Mweb/Chrome - IOU - Scan page keeps loading infinitely[/-][+][HOLD for payment 2024-01-05] Mweb/Chrome - IOU - Scan page keeps loading infinitely[/+]melvin-bot commentedon Dec 29, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
[-][HOLD for payment 2024-01-05] Mweb/Chrome - IOU - Scan page keeps loading infinitely[/-][+][HOLD for payment 2024-01-09] [HOLD for payment 2024-01-05] Mweb/Chrome - IOU - Scan page keeps loading infinitely[/+]melvin-bot commentedon Jan 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue: