Repository navigation
E2E tests failing consistently after PR #32367 merged in #33719
Description
Activity
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Conversation here https://expensify.slack.com/archives/C03TQ48KC/p1703786837284899
Got a PR that should fix this: #33722
- changed the title
[-]E2E tests failing consistently after PR #32367 merged in[/-][+][HOLD for payment 2024-01-05] E2E tests failing consistently after PR #32367 merged in[/+]on Dec 29, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@roryabraham] The PR that introduced the bug has been identified. Link to the PR: [No QA] Improve AdHoc build comment #32367
- [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: it was my PR
- [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
- [@roryabraham] Determine if we should create a regression test for this bug. Nope, it was just a failing automated test.
- [@roryabraham] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: n/a
Closing this out as no payments are due here
- changed the title
[-][HOLD for payment 2024-01-05] E2E tests failing consistently after PR #32367 merged in[/-][+]E2E tests failing consistently after PR #32367 merged in[/+]on Dec 29, 2023 ^ ignore above link, typo in the new issue that I wrote
Reacted by Rory Abraham
If you look at the recent status of the
mainbranch for theProcess new code merged toworkflow, it is consistently failing when not doing a version upgrade (link). This seems to have started happening consistently after this PR was merged. We should remedy this so that our E2E tests can catch bugs for us.