[RUSHAT to complete checklist] [$500] Web - Emoji picker - Holding down on scroll bar and sliding down selects emoji instead of scrolling

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Open a conversation
Click on the emoji picker
Hold down on the scroll bar on the right of the emoji picker
Try to slide down while holding down the scroll bar

Expected Result:

The side bar should be able to scroll down

Actual Result:

Instead of scrolling down the performed action results in selecting the emoji categories

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6327469_1703768696724.emoji_scroll.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c0bac704c1843b72
Upwork Job ID: 1740375313641885696
Last Price Increase: 2023-12-28

Job added to Upwork: https://www.upwork.com/jobs/~01c0bac704c1843b72

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@kbecciv

@kbecciv i can start working on this.... can you assign this to me??

@ayushjha119

📣 @ayushjha119! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sticky header overlaps scroll bar.

What is the root cause of that problem?

The Sticky header from FlashList overlaps scroll bar.

The 1st part of the scroll bar is overlapped and user can't click on it.

What changes do you think we should make in order to solve the problem?

Change the style of the StickyHeader children (because we don't have access to style the StickyHeader div) to give space for the scroll bar.

<View  style={[styles.emojiHeaderContainer, target === 'StickyHeader' ? styles.stickyHeaderEmoji : undefined]}>

where StickyHeader is:

stickyHeaderEmoji: {
	position:  'absolute',
	width:  '-webkit-fill-available',
	...spacing.mh4,
},

POC

007.mp4

To support all browsers we can use the below:

  width: '100%',
  width: '-webkit-fill-available',
  width: '-mos-available',
  width: 'fill-available',

Thank you. Accepted.

@dragnoir

Paying now - p.s. @dragnoir in the future, no need to submit work! We'll pay when the due date has passed.

@rushatgabhane

Paid and job removed.

@rushatgabhane bump to complete the checklist please!

@rushatgabhane

@rushatgabhane bump to complete the checklist

The PR that introduced the bug has been identified. Link to the PR: Migrate EmojiPickerMenu to FlashList #31479
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/31479/files#r1470459109
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. No
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

@jliexpensify

Hi @jliexpensify, I think the checklist was the only pending item here, correct?

@marcochavezf

Yep @marcochavezf - contributors have been paid and job is now closed.

Checklist is a WIP, so I'll close once Rajat updates it.

manual request here - https://staging.new.expensify.com/r/3543070728552287

checklist done

@rushatgabhane

$500 payment approved for @rushatgabhane based on this summary.

Navigation Menu

Repository navigation

[RUSHAT to complete checklist] [$500] Web - Emoji picker - Holding down on scroll bar and sliding down selects emoji instead of scrolling #33709

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

POC

48 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[RUSHAT to complete checklist] [$500] Web - Emoji picker - Holding down on scroll bar and sliding down selects emoji instead of scrolling #33709

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 28, 2023

melvin-bot commented on Dec 28, 2023

melvin-bot commented on Dec 28, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 28, 2023

ayushjha119 commented on Dec 28, 2023

melvin-bot commented on Dec 28, 2023

dragnoir commented on Dec 28, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

POC

dragnoir commented on Dec 28, 2023

48 remaining items

dragnoir commented on Jan 23, 2024

jliexpensify commented on Jan 24, 2024

jliexpensify commented on Jan 24, 2024

jliexpensify commented on Jan 29, 2024

rushatgabhane commented on Jan 29, 2024

marcochavezf commented on Jan 29, 2024

jliexpensify commented on Jan 29, 2024

rushatgabhane commented on Jan 30, 2024

JmillsExpensify commented on Jan 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions