Repository navigation
[HOLD for payment 2024-02-09] [$500] Android - Workspace - WS image is displayed without background #33682
Description
Activity
- changed the title
[-]Android - Workspace - WS image is displayed without background[/-][+][$500] Android - Workspace - WS image is displayed without background[/+]on Dec 28, 2023 Job added to Upwork: https://www.upwork.com/jobs/~010b6d3a83f995ac38
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace image is displayed without background in Android but with background in mweb
What is the root cause of that problem?
Since the SVG migration to using
expo-image, it no longer match this condition, because SVG is no longer React components, it's now statically importedWhat changes do you think we should make in order to solve the problem?
Check if
sourceis number here instead, because the statically imported SVG will havesourceas number, it's native iOS & Android's static asset representation.if (typeof source === 'number' && !transactionID) {The
transactionIDcheck is so that we exclude receipt case, since generic receipt is an image and it should never display as Icon. An alternative of this is that we can move all the checks related to receipt like here and here to above thesourcenumber check. But I prefer thetransactionIDcheck since it's more robust.What alternative solutions did you explore? (Optional)
Since
sourcenumber could be images as well, there could be risk of the image showing as icon if that happens (although currently I didn't find any such case in the app except for the generic receipt above). If we want to avoid that risk entirely, we can add another prop likeisImageto indicate the file type (or add type to thefile), and the condition ofsourceabove will take into account the file type as well, so only if thesourceis number, and it is CSV (or it's not image), we'll use the<Icon>.@NicMendonca @sobitneupane Can we combine this GH with #33616?
As #33616 (comment) seems to solve both issues.
@shubham1206agra they have 2 different root causes, in #33616 the solution that's accepted won't fix this issue.
But we can hold this issue on that one though.
Nope both have the same root cause
And the accepted solution is partially wrong
Reacted by Tienifr and Nguyen Van Duc40 remaining items
- changed the title
[-][$500] Android - Workspace - WS image is displayed without background[/-][+][HOLD for payment 2024-02-09] [$500] Android - Workspace - WS image is displayed without background[/+]on Feb 2, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-09. 🎊
For reference, here are some details about the assignees on this issue:
- @sobitneupane requires payment through NewDot Manual Requests
- @tienifr requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
- [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@sobitneupane] Determine if we should create a regression test for this bug.
- [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Reminder set to pay
Payment summary:
$500 @sobitneupane requires payment through NewDot Manual Requests
$500 @tienifr requires payment automatic offer (Contributor) PAID$500 approved for @sobitneupane based on summary.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.18-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Workspace image must be displayed with background
Actual Result:
Workspace image is displayed without background in Android but with background in mweb
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6327135_1703716298402.az_recorder_20231228_001317.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @MitchExpensify