Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing #33647
Description
Activity
Job added to Upwork: https://www.upwork.com/jobs/~0191d08fb26ea68646
- changed the title
[-]LHN chat row has large spacing[/-][+][$500] LHN chat row has large spacing[/+]on Dec 27, 2023 Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)119 remaining items
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
- changed the title
[-][HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing[/-][+][HOLD for payment 2024-06-18] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing[/+]on Jun 11, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-18. 🎊
For reference, here are some details about the assignees on this issue:
- @abzokhattab requires payment automatic offer (Contributor)
- @getusha requires payment automatic offer (Reviewer)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@getusha] The PR that introduced the bug has been identified. Link to the PR:
- [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@getusha] Determine if we should create a regression test for this bug.
- [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-06-18] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-22] [$250] LHN chat row has large spacing[/+]on Jun 13, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
- @abzokhattab requires payment automatic offer (Contributor)
- @getusha requires payment automatic offer (Reviewer)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@getusha] The PR that introduced the bug has been identified. Link to the PR:
- [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@getusha] Determine if we should create a regression test for this bug.
- [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.18-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation:
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
The LHN chat preview spacing is as in production
Actual Result:
Describe what actually happened
There is more spacing
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
staging
prod
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @bfitzexpensify