Repository navigation
Distance - App redirects to expense report when returning online after editing distance offline #33622
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.@neil-marcellini @allroundexperts @dukenv0307 This is linked to PR you have been involved in, it does seem though that this is already in production if I am not mistaken and given its edge case I would vote this is not a blocker. @tgolen let me know what you think?
I reverted the changes from #33266 locally, and I had trouble reproducing the issue because there is a bug that the PR fixes where you can't save the request in offline mode (clicking the save button does nothing). So, I'm not so sure that PR caused the redirect issue.
I do agree with @mountiny that the redirect issue reported here is not bad enough to be a deploy blocker. Everything works, it's just you end up in a slightly different place and it's easy to go back to the details.
I'm removing the deploy blocker label and I think we should consider opening this bug up to contributors to find the cause of it.
Reacted by Vit HoracekTriggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.23 remaining items
@bfitzexpensify we might want to hold for #33114 as well — it fills the gaps the first PR missed
- changed the title
[-][HOLD #31411 ] Distance - App redirects to expense report when returning online after editing distance offline[/-][+][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/+]on Mar 5, 2024 Thanks for the heads-up @paultsimura, I'll get QA to pause on the retesting for the moment then.
- changed the title
[-][HOLD #33114] Distance - App redirects to expense report when returning online after editing distance offline[/-][+]Distance - App redirects to expense report when returning online after editing distance offline[/+]on Mar 15, 2024 #33114 is live - getting QA to retest this.
@bfitzexpensify Issue is not reproducible by the tester.
20240315_221608.mp4
Great! Let's close this one out then.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #33266
Action Performed:
Precondition: There are three addresses saved in Recent destinations
Expected Result:
App will stay in distance request details page
Actual Result:
App redirects to expense report automatically
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6326377_1703618482455.bandicam_2023-12-26_23-57-29-307.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @bfitzexpensify