Repository navigation
[$500] Avatar - Avatar is blank instead of placeholder and no spinner when loading it offline #33614
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Issue is not reproducible on production
Bug6326350_1703616605871.production.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
I don't feel strongly that this needs to be a blocker. When you come back online the images are restored. But will leave it to the deployer to make the final decision.
96 remaining items
Is there any explanation for why we couldn't get this merged in that time?
We never arrived at a fix that would work for all of the cases, this one specifically. I agree we should have been faster, no payment seems fair to me personally
Thanks for the comments. I think skipping payment for missing on urgency here is fair. Closing this one out.
@marcaaron @bfitzexpensify Our PR #35639 fixed this issue and we completed it a long time ago. The problem is I tried to explain the confusion in this case #35639 (review) from @eVoloshchak which is not a bug. The PR #38674 fixed this issue and has the same idea as my proposal, the only difference is instead of using the current fill color of the default avatar we apply the theme color for this avatar in this PR #38674. So I think payment here for C and C+ is fair since we spent lots of effort in the PR and it's almost completed.
@bfitzexpensify Please check my comment above when you have a chance.
Reopened and made @bfitzexpensify the owner to get 👀, removed 'reviewing' too.
Reviewed again. Agree that there was a substantial amount of work, but I still think it missed the mark on urgency. Given that, I think a 50% payout is fair here.
Payment summary:
@dukenv0307 to be paid $250 for contributor work - offer sent via Upwork
@eVoloshchak to be paid $250 for C+ work via manual requestReacted by Eugene VoloshchakThanks @bfitzexpensify for helping here, I've accepted the offer.
You're very welcome. Payment complete. Closing this out again.
$250 approved for @eVoloshchak
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal
Slack conversation:
Action Performed:
Expected Result:
In Step 4, users with custom avatar will show the avatar placeholder (production behavior - circular head with body with green background).
In Step 7, spinner will be shown when loading user avatar.
Actual Result:
In Step 4, the users with custom avatar are blank and gray.
In Step 7, the spinner only appears for a split second.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6326350_1703616605864.staging.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @bfitzexpensify