Skip to content

[HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon #33594

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to Settings > Workspaces > any workspace.

Expected Result:

All icons are displayed properly.

Actual Result:

Card icon is shown as a green square icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b583b60c7afce86e
  • Upwork Job ID: 1739665839943921664
  • Last Price Increase: 2023-12-26
  • Automatic offers:
    • situchan | Contributor | 28070426
    • aswin-s | Contributor | 28070450
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. github-actions commented on Dec 26, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mountiny commented on Dec 26, 2023

    @mountiny
    Contributor

    Potentially related to the expo image update, but its odd this is only happening on native android

  4. mountiny commented on Dec 26, 2023

    @mountiny
    Contributor

    QA confirmed only happening on native android

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 26, 2023
  6. changed the title [-]Android - Workspace - Card icon is shown as a green square icon[/-] [+][$500] Android - Workspace - Card icon is shown as a green square icon[/+] on Dec 26, 2023
  7. melvin-bot commented on Dec 26, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 26, 2023
  9. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  10. mountiny commented on Dec 26, 2023

    @mountiny
    Contributor

    Actually found that this will most likely be related to the expo image update as there were some other icons which had similar issue https://expensify.slack.com/archives/C01GTK53T8Q/p1703186271886829

  11. 60 remaining items

  12. changed the title [-][HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$250] Android - Workspace - Card icon is shown as a green square icon[/-] [+][HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon[/+] on Jan 5, 2024
  13. melvin-bot commented on Jan 9, 2024

    @melvin-bot

    @JmillsExpensify, @aswin-s, @mountiny, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. mountiny commented on Jan 10, 2024

    @mountiny
    Contributor

    @situchan can you please complete the checklist here?

    Summary is $250 to @aswin-s and $250 to @situchan

  15. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    @JmillsExpensify, @aswin-s, @mountiny, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  16. situchan commented on Jan 11, 2024

    @situchan
    Contributor

    Not able to find offending PR but from deploy checklist, I think expo-image PR is the culprit.
    This was caught by QA team during regression test so no need new regression test.
    To prevent such bugs further, it would be good to add eslint rule to avoid duplicated resource file names after excluding -, but not a big deal.

  17. mountiny commented on Jan 11, 2024

    @mountiny
    Contributor

    @JmillsExpensify ready for payment

  18. melvin-bot commented on Jan 15, 2024

    @melvin-bot

    @JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  19. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    @JmillsExpensify, @aswin-s, @mountiny, @situchan Eep! 4 days overdue now. Issues have feelings too...

  20. melvin-bot commented on Jan 19, 2024

    @melvin-bot

    @JmillsExpensify, @aswin-s, @mountiny, @situchan Still overdue 6 days?! Let's take care of this!

  21. JmillsExpensify commented on Jan 24, 2024

    @JmillsExpensify
    Contributor

    Payment summary:

  22. JmillsExpensify commented on Jan 24, 2024

    @JmillsExpensify
    Contributor

    All contracts paid out, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions