Repository navigation
[HOLD for payment 2024-01-04] [$125] Web - Emoji - Flag emoji category is missing #33593
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @iwiznia (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Emoji - Flag emoji category is missing
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
Add back changes in #32396
So just remove windows code here:
Lines 36 to 49 in de5a943
- added and removed
on Dec 26, 2023 This is not a blocker and caused by two changes at the same time @TMisiukiewicz will handle this as a follow up to their PR, left a comment here https://github.com/Expensify/App/pull/31479/files#r1436483172
42 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
- @mkhutornyi requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
- [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@mkhutornyi] Determine if we should create a regression test for this bug.
- [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@JmillsExpensify, @mountiny, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?
this issue stemmed from incorrectly resolved conflicts and th author of the PR has already been notified, I think that is enough as far as the checklist goes here
Payment here is $125 to @mkhutornyi
No regression test required for this either I think
@JmillsExpensify, @mountiny, @mkhutornyi Still overdue 6 days?! Let's take care of this!
@JmillsExpensify, @mountiny, @mkhutornyi 10 days overdue. I'm getting more depressed than Marvin.
@JmillsExpensify, @mountiny, @mkhutornyi 12 days overdue now... This issue's end is nigh!
waiting for payment
Payment made based on this summary!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Flag emoji category is present.
Actual Result:
Flag emoji category is missing. It is present on production.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensify