Skip to content

[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-03] Expense - Expense preview with a manual and ongoing scan does not show "x request, y scanning" #33512

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create a new workspace
  2. Go to workspace chat
  3. Create a manual request
  4. Create a scan request

Expected Result:

The expense preview in the workspace chat will show "x request, y scanning

Actual Result:

The expense preview in the workspace chat just shows "Receipt", as if the receipt in the Scan request is part of the manual expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324154_1703264366246.bandicam_2023-12-22_21-52-25-983__2_.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Dec 22, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. rlinoz commented on Dec 22, 2023

    @rlinoz
    Contributor

    This is a regression from #32469

  4. rlinoz commented on Dec 22, 2023

    @rlinoz
    Contributor

    Opened a PR to fix it

  5. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    PR is up and merged, but I dont think this needs to be CPed its a minor change so demoting this to not a blocker

  6. mountiny commented on Dec 26, 2023

    @mountiny
    Contributor

    Per this comment #33576 (comment) this is still failing on some platforms cc @kbecciv do you have more details?

  7. kbecciv commented on Dec 26, 2023

    @kbecciv

    It failed on mWeb, Desktop and IOS app

    RPReplay_Final1703593634.mp4
  8. 30 remaining items

  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 18, 2024
  10. melvin-bot commented on Jan 18, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  11. rlinoz commented on Jan 18, 2024

    @rlinoz
    Contributor

    @allroundexperts is due payment for reviewing the PR

  12. twisterdotcom commented on Jan 18, 2024

    @twisterdotcom
    Contributor

    This would be on Jan 25 right? The automation should send offers to you both. But I will handle it then if not.

  13. rlinoz commented on Jan 22, 2024

    @rlinoz
    Contributor

    Moving to weekly since it is on hold for payment.

  14. added and removed on Jan 22, 2024
  15. twisterdotcom commented on Jan 25, 2024

    @twisterdotcom
    Contributor

    Okay, so I think the payment summary is just:

  16. JmillsExpensify commented on Jan 30, 2024

    @JmillsExpensify
    Contributor

    $500 payment approved for @allroundexperts based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions