[LOW] [Splits] [$500] Request – Unable to Request money twice to the same user you have no conversation with.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.16-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Prerequisite: The new account you're requesting money from must have an updated user name in NewDot, ie. first name = Matt, last = test, as seen in Matt A's vid below.

Action Performed:

Go to https://staging.new.expensify.com/
Log in
Click the FAB menu in LHN
Click on "Request money" Manual.
Enter an amount into the BNP and click Next
Enter an email of the user you have no conversation with and click on the “Request …”
Go back to the LHN and create one more request with the same user (repeat steps 3-6)

Expected Result:

Two requests are in DM with the user you just sent a request to.

Actual Result:

Error appears when create the second request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6323555_1703223322049.Unable_to_Request_money_twice_to_the_new_user.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01497816ffe49c0bd0
Upwork Job ID: 1738134853342339072
Last Price Increase: 2024-04-20

Job added to Upwork: https://www.upwork.com/jobs/~01497816ffe49c0bd0

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@abdulrahuman5196

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

This error is still exist? I can't find this error. It works well.

📣 @handaniel214! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

Requesting money twice to the same user that we haven't chatted with before will give an error.

What is the root cause of that problem?

This has the same root cause as #22031 (comment).

In summary, when we create a money request with a user that we haven't chatted with before, we don't have their login yet. If we try to search for that same user when selecting the money request participant, we won't be able to find it and it will create a new optimistic account (with a different accountID) because we filter out any user that doesn't have a login.

App/src/libs/OptionsListUtils.js

Lines 1213 to 1217 in 862b0ea

    
           // We're only picking personal details that have logins set 
        
           // This is a temporary fix for all the logic that's been breaking because of the new privacy changes 
        
           // See https://github.com/Expensify/Expensify/issues/293465 for more context 
        
           // Moreover, we should not override the personalDetails object, otherwise the createOption util won't work properly, it returns incorrect tooltipText 
        
           const havingLoginPersonalDetails = !includeP2P ? {} : _.pick(personalDetails, (detail) => Boolean(detail.login) && !detail.isOptimisticPersonalDetail);

Because the accountID is different, we created a new chat report and it will throw an error because we already have an existing chat with that user.

In #22031, we are holding for #22480, but #22480 actually doesn't fix #22031. In #22480, we only fix an issue where the user is unable to create a money request from within the chat by allowing the request to accept an account ID, so if the login is missing, the request will still succeed.

What changes do you think we should make in order to solve the problem?

I tested doing money request, split, and send money and all of them can work even though the email/login is missing. We also have this PR to allow the user to do a split bill from within the chat with a user without login.

So, I believe it makes sense to show a user even without a login on the money request participant list as the BE can already handle it. We can have a new flag called includePersonalDetailsWithoutLogin and only set it to true for the money request participant list. Basically, we will have the same behavior between making a money request from FAB and from within the chat.

_.pick(personalDetails, (detail) => !includePersonalDetailsWithoutLogin && Boolean(detail.login) && !detail.isOptimisticPersonalDetail)

(or just remove the login logic for all cases)

Issue is reproducible during KI retests.

Add Help Wanted label.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Waiting for proposals.

Not able to reproduce this on Android (Chrome)

Don't see Request Money option (is some setting required for it?)
Tried to reproduce using Track Expense instead - but no issue found (recording below)

Screenrecorder-2024-04-19-15-42-44-209.mp4

Is this issue mac only?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Gonna close this, wasn't able to repro AND it's 5 months old, nav is totally different now.

2024-04-23_14-43-13.mp4

Navigation Menu

Repository navigation

[LOW] [Splits] [$500] Request – Unable to Request money twice to the same user you have no conversation with. #33487

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

65 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// We're only picking personal details that have logins set
	// This is a temporary fix for all the logic that's been breaking because of the new privacy changes
	// See https://github.com/Expensify/Expensify/issues/293465 for more context
	// Moreover, we should not override the personalDetails object, otherwise the createOption util won't work properly, it returns incorrect tooltipText
	const havingLoginPersonalDetails = !includeP2P ? {} : _.pick(personalDetails, (detail) => Boolean(detail.login) && !detail.isOptimisticPersonalDetail);

[LOW] [Splits] [$500] Request – Unable to Request money twice to the same user you have no conversation with. #33487

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 22, 2023

rainbowunicorn18 commented on Dec 22, 2023

melvin-bot commented on Dec 22, 2023

bernhardoj commented on Dec 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

65 remaining items

mvtglobally commented on Apr 4, 2024

mallenexpensify commented on Apr 6, 2024

melvin-bot commented on Apr 6, 2024

melvin-bot commented on Apr 13, 2024

mallenexpensify commented on Apr 15, 2024

lokesh-singhania commented on Apr 19, 2024

melvin-bot commented on Apr 20, 2024

mallenexpensify commented on Apr 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions