[HOLD for payment 2024-01-22] [$500] Threads - __ fake __ appears in Search list after leaving and rejoining thread

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

Go to workspace chat
Send a message
Right click on the message > Reply in thread
Send a message
Leave the thread
Rejoin the thread by clicking on the message in the main chat and sending a reply
Click on the Search icon
Create a split bill with __ fake __

Expected Result:

__ fake __ is not present in the Search list

Actual Result:

__ fake __ is present in the Search list
When splitting bill with __ fake __, app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6322730_1703166738967.bandicam_2023-12-21_21-50-45-932.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011134428cbeec541d
Upwork Job ID: 1737841437304057856
Last Price Increase: 2024-01-04
Automatic offers:

paultsimura | Contributor | 28081594

@conorpendergrast

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~011134428cbeec541d

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The __fake__ account is present in the options list while searching.

What is the root cause of that problem?

We do not filter out the __fake__ account with accountID=0 while building the list of participants.

This is the fake account in Onyx, and we should filter it out when building the list of suggestions, as it is used solely for sending the system messages and should not be interacted with:

What changes do you think we should make in order to solve the problem?

Here, we should ignore the fake account with accountID=0 and login='__fake__' as well:

const havingLoginPersonalDetails = !includeP2P ? {} : _.pick(personalDetails, (detail) => Boolean(detail.login) && !detail.isOptimisticPersonalDetail  && detail.accountID !== 0);

App/src/libs/OptionsListUtils.js

Line 1217 in df98114

    
           const havingLoginPersonalDetails = !includeP2P ? {} : _.pick(personalDetails, (detail) => Boolean(detail.login) && !detail.isOptimisticPersonalDetail);

What alternative solutions did you explore? (Optional)

I have debugged it, It is a backend issue when we open a thread we have left from we call open child report here

App/src/pages/home/report/ReportActionItemThread.tsx

Lines 45 to 46 in 2f7c2b2

    
               Report.navigateToAndOpenChildReport(childReportID); 
        
           }}

the server response for OpenReport command has the __fake__ personal detail in the list; it only happens for workspace chat not 1:1 chat

should be fixed in BE

when we open a thread we have left from

It's not necessary to leave the thread. This response comes whenever we open an existing thread in a workspace chat.
And while it may be fixed from the BE, it also can be fixed on the FE side without any major difference.

Reviewing label has been removed, please complete the "BugZero Checklist".

@eVoloshchak

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Filter out personal details with falsy accountIDs #34015

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@paultsimura requires payment automatic offer (Contributor)

@eVoloshchak

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/362667

Looks like we're ready for the checklist and payment!

The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, the data is returned by back end
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is a pretty minor bug, updating our processes/checklists isn't worth it
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? No
The bug has little impact, but it's related to the part of the application that's used a lot and it's easy to test, so we might add a regression test (testing steps from fix: Filter out personal details with falsy accountIDs #34015 can be used)

Regression Test Proposal

Go to a workspace chat
Send a message
Right-click on the message > Reply in thread
Send a message
Leave the thread
Rejoin the thread by clicking on the message in the main chat and sending a new reply
Click FAB -> Request Money
Enter amount and proceed to user selection

Do we agree 👍 or 👎

@paultsimura

Payouts due:

Contributor: $500 @paultsimura - contract

Contributor+: $500 @eVoloshchak through NewDot Manual Requests

Upwork job is here.

@eVoloshchak

Contract paid via Upwork, payout summary added.

Regression test steps look good @eVoloshchak, thanks! Regression test created: https://github.com/Expensify/Expensify/issues/362667

Looks like that's it; thanks everyone

Looks like I didn't request the payment for this (no "Approved payment for.." message). Cannot find the request on Expensify either.
I'll request the payment, but please double-check this hasn't been paid already. Thanks!

I can confirm that this was not paid via Upwork (see summary above) and I don't have the context for a manual request!

@eVoloshchak

$500 approved for @eVoloshchak based on this summary.

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-22] [$500] Threads - fake appears in Search list after leaving and rejoining thread #33415

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-01-22] [$500] Threads - __ fake __ appears in Search list after leaving and rejoining thread #33415

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

melvin-bot commented on Dec 21, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 21, 2023

paultsimura commented on Dec 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

FitseTLT commented on Dec 21, 2023

paultsimura commented on Dec 21, 2023

23 remaining items

melvin-bot commented on Jan 15, 2024

melvin-bot commented on Jan 15, 2024

melvin-bot commented on Jan 15, 2024

dangrous commented on Jan 22, 2024

eVoloshchak commented on Jan 22, 2024

conorpendergrast commented on Jan 22, 2024

conorpendergrast commented on Jan 22, 2024

eVoloshchak commented on Feb 9, 2024

conorpendergrast commented on Feb 9, 2024

JmillsExpensify commented on Feb 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[HOLD for payment 2024-01-22] [$500] Threads - fake appears in Search list after leaving and rejoining thread #33415