[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.15-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Issue found when executing PR #32901

Action Performed:

1. Go to Settings > Profile > Contact method
2. Click New contact method
3. Enter a new email
4. Click on the newly added email
5. Click Remove

Expected Result:

Delete confirmation pop-up appears without delay

Actual Result:

Delete confirmation pop-up appears after slight delay.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6322617_1703162575019.bandicam_2023-12-21_20-18-49-816.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b88b71e8f06ec60
• Upwork Job ID: 1737900809599180800
• Last Price Increase: 2023-12-21
• Automatic offers:
• shubham1206agra | Reviewer | 28067079
• FitseTLT | Contributor | 28067080

Issue Owner

Current Issue Owner: @isabelastisser

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete contact method confirmation pop-up appears after slight delay

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 222 to 227 in 2f7c2b2

	toggleDeleteModal(isOpen) {
	InteractionManager.runAfterInteractions(() => {
	this.setState({isDeleteModalOpen: isOpen});
	});
	Keyboard.dismiss();
	}

What is the root cause of that problem?

It is caused by this pr to display modal after keyboard is dismissed

What changes do you think we should make in order to solve the problem?

We should do that only for touch screen

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 222 to 227 in 2f7c2b2

	toggleDeleteModal(isOpen) {
	InteractionManager.runAfterInteractions(() => {
	this.setState({isDeleteModalOpen: isOpen});
	});
	Keyboard.dismiss();
	}

change it to

toggleDeleteModal(isOpen) {
        if (canUseTouchScreen()) {
            InteractionManager.runAfterInteractions(() => {
                this.setState({isDeleteModalOpen: isOpen});
            });
            Keyboard.dismiss();
        } else {
            this.setState({isDeleteModalOpen: isOpen});
        }
    }

What alternative solutions did you explore? (Optional)

[allroundexperts]

Hm... Is this a bug? We decided to run it after all interactions.

[NikkiWines]

This seems to only occur when the contact method is unvalidated, which makes sense given @allroundexperts's and @FitseTLT's comments above. I do think it comes across a bit buggy and we should fix it. Especially if we're applying logic that only impacts touchscreen devices to all platforms

[NikkiWines]

Anyway, @FitseTLT your solution looks good to me! Adding the relevant labels and assigning you 👍

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync