[PAID] [$500] Status - Custom time page loads infinitely in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Log in and do not visit custom time page
Go offline
Go to Settings > Profile > Status
Click Clear after
Click Custom
Click Time

Expected Result:

Time selection page will open without issue

Actual Result:

Time selection page loads infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6321550_1703091917140.bandicam_2023-12-20_21-58-55-875.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ab5fa243901ed9cb
Upwork Job ID: 1737525375053193216
Last Price Increase: 2023-12-20
Automatic offers:

paultsimura | Contributor | 28067092

@strepanier03

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~01ab5fa243901ed9cb

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@narefyev91

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status - Custom time page loads infinitely in offline mode

What is the root cause of that problem?

setTimePage shows FullScreenLoadingIndicator if is it still loading:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

    
           if (lodashGet(privatePersonalDetails, 'isLoading', true)) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

This will keep on loading when offline

What changes do you think we should make in order to solve the problem?

We should add a FullPageOfflineBlockingView when the user is offline

Proposal

Please re-state the problem that we are trying to solve in this issue.

Time selection page loads infinitely

What is the root cause of that problem?

When we offline without private personal detail, the loading page is show here

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Line 36 in 88631a0

if (lodashGet(privatePersonalDetails, 'isLoading', true)) {

What changes do you think we should make in order to solve the problem?

I think on this page, we want to get currentPersonalDetail to get the current time to display the default value of the form if the draft time is empty but we get the wrong data here.

We should get currentPersonalDetail by using withCurrentPersonalDetail HOC and then get clearAfter from currentPersonalDetail.status to display if the draft custom status is empty.

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Line 36 in 88631a0

if (lodashGet(privatePersonalDetails, 'isLoading', true)) {

And we can display loading page when currentPersonalDetail.login is empty.

We should update other custom status pages with this approach.

What alternative solutions did you explore? (Optional)

NA

Proposal

Please re-state the problem that we are trying to solve in this issue.

In offline, the status timer is always loading.

What is the root cause of that problem?

We are checking for the privatePersonalDetails to be loaded before showing the TimePicker and displaying the loader otherwise:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

    
           if (lodashGet(privatePersonalDetails, 'isLoading', true)) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

What changes do you think we should make in order to solve the problem?

I've checked the code – the value of privatePersonalDetails is not used anywhere, seems like it is a redundant code that was missed during development (probably, this page was initially copy-pasted from some other that uses privatePersonalDetails, most likely from DateOfBirthPage – commit).

We can remove this piece of code as well as all the code related to the privatePersonalDetails on this page:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

    
           if (lodashGet(privatePersonalDetails, 'isLoading', true)) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

What alternative solutions did you explore? (Optional)

@paultsimura

Proposal from @paultsimura looks good to me #33369 (comment)
Seems we do not need that check, in case we do not use privatePersonalDetails anywhere in that flow
🎀 👀 🎀 C+ reviewed

Reviewing label has been removed, please complete the "BugZero Checklist".

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Status – remove redundant privatePersonalDetails dependencies #33440

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue - @paultsimura - $500 via Upwork
Contributor+ that helped on the issue and/or PR - N/A

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Contributor)
@narefyev91 does not require payment (Contractor)

@blimpich

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@blimpich] The PR that introduced the bug has been identified. Link to the PR: Status clear after #24620
[@blimpich] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24620/files#r1433890095
[@blimpich] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a, the PR that introduced this was part of a large feature branch, and this bug is relatively minor, so I don't think its worth discussing a change to the PR review checklist
[@paultsimura / @narefyev91] Determine if we should create a regression test for this bug.
[@paultsimura / @narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Payment has been handled and part of the checklist. I'll check here tomorrow for the rest of the checklist responses and close when that's finished up.

@paultsimura

@paultsimura @narefyev91 - Do we need to do the regresssion test at all? I think not because an indefinite load would be caught with normal testing.

I plan to close this tomorrow if I don't hear from you.

From my POV, no regression test is needed here as the issue was caused by redundant code missed during the initial feature development (I'm not a C+ though).

@paultsimura

Thank you @paultsimura - I'm going to close this and if a reg test is needed we can reopen and I'll take care of it.

Navigation Menu

Repository navigation

[PAID] [$500] Status - Custom time page loads infinitely in offline mode #33369

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

[PAID] [$500] Status - Custom time page loads infinitely in offline mode #33369

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 20, 2023

melvin-bot commented on Dec 20, 2023

melvin-bot commented on Dec 20, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 20, 2023

neonbhai commented on Dec 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

dukenv0307 commented on Dec 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

paultsimura commented on Dec 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

narefyev91 commented on Dec 21, 2023

17 remaining items

melvin-bot commented on Dec 27, 2023

melvin-bot commented on Dec 27, 2023

melvin-bot commented on Dec 27, 2023

strepanier03 commented on Jan 3, 2024

strepanier03 commented on Jan 8, 2024

paultsimura commented on Jan 8, 2024

strepanier03 commented on Jan 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions