Repository navigation
[HOLD for payment 2024-01-11] [$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded #33363
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Navigate to IOU request details that has a receipt
- Click on the receipt
- Click 3-dot menu > Replace
- Upload another receipt
- After the upload is complete, download the receipt
Expected Result:
The latest receipt will be downloaded
Actual Result:
The previous receipt is downloaded, while the receipt file name is the name of the latest receipt
On Android and iOS app, it downloads the previous receipt (file name is not affected/not relevant) after replacing the receipt
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6321355_1703082153236.bandicam_2023-12-20_22-14-39-707.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0113378cba031fc595
- Upwork Job ID: 1737485735446364160
- Last Price Increase: 2023-12-20
- Automatic offers:
- shubham1206agra | Contributor | 28077368
Activity
melvin-bot commentedon Dec 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0113378cba031fc595
[-]IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded[/-][+][$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded[/+]melvin-bot commentedon Dec 20, 2023
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 20, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)namhihi237 commentedon Dec 20, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The link source download does not update when replace the image
What is the root cause of that problem?
Currently, when the source changes we don't update in the
threeDotsMenuItems.What changes do you think we should make in order to solve the problem?
We should add the
sourceinto dependenceWhat alternative solutions did you explore? (Optional)
vikssevishnu commentedon Dec 20, 2023
I am trying to access the issue details using the link "https://stackoverflow.com/c/expensify/questions/14418" but i am getting you do not have access. Can you help on it ?
melvin-bot commentedon Dec 20, 2023
📣 @vikssevishnu! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
vikssevishnu commentedon Dec 20, 2023
Contributor details
Your Expensify account email: vishnu.vikas19@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a59961216a1ee633?viewMode=1
21 remaining items
[-][$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded[/-][+][HOLD for payment 2024-01-11] [$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded[/+]melvin-bot commentedon Jan 4, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-11. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jan 5, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
alexpensify commentedon Jan 9, 2024
@shubham1206agra - can you please identify if this PR triggered the deploy blocker or if there is another reason for this automation? Thanks!
shubham1206agra commentedon Jan 9, 2024
Oh it's a false alert actually
alexpensify commentedon Jan 9, 2024
@shubham1206agra - can you please share more context as to why the alert is wrong? It will be helpful to have it recorded here. Thanks!
shubham1206agra commentedon Jan 9, 2024
@alexpensify #33586 is the offending PR. Some contributor marked this by mistake as this issue is already deployed to production.
alexpensify commentedon Jan 9, 2024
Thank you! I will continue the process to prepare for the payment date.
alexpensify commentedon Jan 11, 2024
Based on the 👎🏼 here #33363 (comment) and the note here #33363 (comment), there is no payment action here since this issue was handled in other GH. I confirmed the Upwork job is closed too.