Repository navigation
[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Sign up - App crashes when signing up with a new account via magic link #33354
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Not reproducible in production
Screen_Recording_20231220_193915_New.Expensify.mp4
I can reproduce it with 100% success rate on local with latest main performing the following actions:
Precondition: App must be killed / closed (not opened in background) before running the steps below.
- Launch New Expensify app.
- Enter email account and tap Continue.
- While on magic code page, navigate to your email and tap on the magic link.
Issue seems to be caused by the following line of code:
App/src/libs/Navigation/linkTo.ts
Line 83 in 9ea6b39
because the
rootState.routesisundefinedwhen attempting deep-link login first time the app is opened.iOS: Native - Screenshot
The issue does not occur on subsequent trials if the app is not killed / closed and I think this is because subsequently the
rootState.routesis notundefinedanymore.Proposal
Please re-state the problem that we are trying to solve in this issue.
Sign up - App crashes when signing up with a new account via magic link
What is the root cause of that problem?
This is regression from #32473
What changes do you think we should make in order to solve the problem?
Like old code, optional chaining should be added
Hello! Thank you for finding the cause of the problem :) I will add a fix in this PR which is also related to LHP #33359
The crash fix needs to be CPed. I don't think #33359 should be necessarily CPed.
Can we fix separately?Closing, fix was CP'd
- changed the title
[-]Sign up - App crashes when signing up with a new account via magic link[/-][+][HOLD for payment 2023-12-28] Sign up - App crashes when signing up with a new account via magic link[/+]on Dec 21, 2023 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
- changed the title
[-][HOLD for payment 2023-12-28] Sign up - App crashes when signing up with a new account via magic link[/-][+][HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Sign up - App crashes when signing up with a new account via magic link[/+]on Dec 22, 2023 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.14-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition: App must be freshly installed, or clear app data before running the steps below.
Expected Result:
App does not crash.
Actual Result:
App crashes.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6321189_1703076281038.Screen_Recording_20231220_193139_One_UI_Home__1_.mp4
View all open jobs on GitHub