You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[hold for payment 2024-04-17] - Avatar placeholder remains in dark mode when app is in light mode #33161
Version Number: v1.4.13-4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal team Slack conversation:
Action Performed:
Precondition: App is in light mode.
Launch New Expensify app.
Go offline.
Tap Search.
Look for user with placeholder avatar.
Expected Result:
The avatar placeholder will be displayed in light mode.
Actual Result:
The avatar placeholder remains in dark mode.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is just the image we use for the fallback avatar, so it's not technically a bug. @dubielzyk-expensify do you think we should use a theme-specific image here?
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
All set to issue payment here. Only payment is $250 to @s77rt via upwork for C+ review. (Would've normally been $500 based on when the issue was created, but this one had a regression).
Activity
github-actions commentedon Dec 15, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Julesssss commentedon Dec 15, 2023
This isn't worth blocking the deploy, so I removed the label.
Krishna2323 commentedon Dec 15, 2023
melvin-bot commentedon Dec 15, 2023
Triggered auto assignment to @dubielzyk-expensify (
Design), see these Stack Overflow questions for more details.grgia commentedon Dec 15, 2023
This is just the image we use for the fallback avatar, so it's not technically a bug. @dubielzyk-expensify do you think we should use a theme-specific image here?
64 remaining items
melvin-bot commentedon Apr 15, 2024
This issue has not been updated in over 15 days. @s77rt, @grgia, @joekaufmanexpensify, @dubielzyk-expensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
joekaufmanexpensify commentedon Apr 22, 2024
Sounds good. TY!
joekaufmanexpensify commentedon Apr 22, 2024
All set to issue payment here. Only payment is $250 to @s77rt via upwork for C+ review. (Would've normally been $500 based on when the issue was created, but this one had a regression).
joekaufmanexpensify commentedon Apr 22, 2024
OG upwork job is closed, so I opened a new one.
joekaufmanexpensify commentedon Apr 22, 2024
@s77rt offer sent for $250!
s77rt commentedon Apr 22, 2024
@joekaufmanexpensify Accepted! Thanks!
joekaufmanexpensify commentedon Apr 22, 2024
@s77rt $250 sent and contract ended!
joekaufmanexpensify commentedon Apr 22, 2024
Upwork job closed.
joekaufmanexpensify commentedon Apr 22, 2024
All set. Thanks everyone!