Skip to content

[hold for payment 2024-04-17] - Avatar placeholder remains in dark mode when app is in light mode #33161

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.13-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

Precondition: App is in light mode.

  1. Launch New Expensify app.
  2. Go offline.
  3. Tap Search.
  4. Look for user with placeholder avatar.

Expected Result:

The avatar placeholder will be displayed in light mode.

Actual Result:

The avatar placeholder remains in dark mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

Bug6314487_1702642885688.Screen_Recording_20231215_031248_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b86fc7d9a009aa8d
  • Upwork Job ID: 1737654517482057728
  • Last Price Increase: 2023-12-21
Issue OwnerCurrent Issue Owner: @grgia

Activity

  1. github-actions commented on Dec 15, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 15, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 15, 2023
  4. Julesssss commented on Dec 15, 2023

    @Julesssss
    Contributor

    This isn't worth blocking the deploy, so I removed the label.

  5. Krishna2323 commented on Dec 15, 2023

    @Krishna2323
  6. melvin-bot commented on Dec 15, 2023

    @melvin-bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  7. grgia commented on Dec 15, 2023

    @grgia
    Contributor

    This is just the image we use for the fallback avatar, so it's not technically a bug. @dubielzyk-expensify do you think we should use a theme-specific image here?

  8. 64 remaining items

  9. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @s77rt, @grgia, @joekaufmanexpensify, @dubielzyk-expensify eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  10. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    Sounds good. TY!

  11. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    All set to issue payment here. Only payment is $250 to @s77rt via upwork for C+ review. (Would've normally been $500 based on when the issue was created, but this one had a regression).

  12. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    OG upwork job is closed, so I opened a new one.

  13. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    @s77rt offer sent for $250!

  14. s77rt commented on Apr 22, 2024

    @s77rt
    Member

    @joekaufmanexpensify Accepted! Thanks!

  15. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    @s77rt $250 sent and contract ended!

  16. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  17. joekaufmanexpensify commented on Apr 22, 2024

    @joekaufmanexpensify
    Contributor

    All set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DesignEngineeringInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions