Skip to content

[HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard #33118

Closed
Closed
[HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard#33118
Assignees
tylerkaraszewskijliexpensifysituchandummy-1111
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Description

@lanitochka17
lanitochka17
opened on Dec 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Intenral Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with any account
  3. Navigate to the conversation between user A and B in both devices
  4. Send two messages to user B
  5. As user A press ArrowUp in the DM. Verify that the last message user A sent in the chat enters edit mode
  6. Delete all the text while editing the comment and press Enter
  7. Press ArrowUp in the DM

Expected Result:

The first message sent in step 4 enters edit mode

Actual Result:

Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313468_1702579313132.Last_message_edit_mode_doesn_t_open_when_Press_ArrowUp.mp4

View all open jobs on GitHub

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 14, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Dec 14, 2023

  3. github-actions commented on Dec 14, 2023

    @github-actions
    github-actionsBot
    on Dec 14, 2023 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    tylerkaraszewski
    on Dec 14, 2023

  5. melvin-bot commented on Dec 14, 2023

    @melvin-bot
    melvin-botBot
    on Dec 14, 2023 – with Melvin Bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. situchan commented on Dec 14, 2023

    @situchan
    situchan
    on Dec 14, 2023
    Contributor

    This is regression from #32474
    @tylerkaraszewski if we end up reverting approach, feel free to merge #33133 since it's straight revert

  7. dukenv0307 commented on Dec 15, 2023

    @dukenv0307
    dukenv0307
    on Dec 15, 2023
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

    What is the root cause of that problem?

    This is regression from this PR #32474 which makes composer doesn't re-focus after deleting the message

    What changes do you think we should make in order to solve the problem?

    1. Revert this PR fix: hide pending deleted actions #32474

    2. To fix the issue of this PR fix: hide pending deleted actions #32474, We should check here if the reportAction is deleted by using isDeletedAction, we will return false because this reportAction still in the list of reportActions with optimistic data but it's invisible in the UI.

    if (ReportActionsUtils.isDeletedAction(reportAction) && !isOffline) {
    return false;
}

    App/src/pages/home/report/ReportActionsList.js

    Line 334 in 3a44f77

    let shouldDisplay = false;

    What alternative solutions did you explore? (Optional)

  8. Julesssss
    added
    DailyKSv2
    and removed
    HourlyKSv2
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 15, 2023

  9. Julesssss commented on Dec 15, 2023

    @Julesssss
    Julesssss
    on Dec 15, 2023
    Contributor

    I can reproduce but this is only occuring on web/desktop and is a minor issue. Removing blocker label

  10. situchan commented on Dec 15, 2023

    @situchan
    situchan
    on Dec 15, 2023
    Contributor

    @s-alves10 can you please handle this as regression?

  11. dummy-1111 commented on Dec 15, 2023

    @dummy-1111
    dummy-1111
    on Dec 15, 2023
    Contributor

    @situchan Yes, I'll

  12. MonilBhavsar commented on Dec 15, 2023

    @MonilBhavsar
    MonilBhavsar
    on Dec 15, 2023
    Contributor

    @s-alves10 thanks! If you don't mind, should I assign this issue to you?

  13. 18 remaining items

  14. melvin-bot
    added
    DailyKSv2
    on Jan 16, 2024

  15. situchan commented on Jan 17, 2024

    @situchan
    situchan
    on Jan 17, 2024
    Contributor

    Please assign me here for PR review

  16. MonilBhavsar commented on Jan 17, 2024

    @MonilBhavsar
    MonilBhavsar
    on Jan 17, 2024
    Contributor

    There was a suspicion that PR linked to this issue has caused a regression #34419
    @s-alves10 @situchan anyone of you can please confirm, thank you!

  17. situchan commented on Jan 17, 2024

    @situchan
    situchan
    on Jan 17, 2024
    Contributor

    There was a suspicion that PR linked to this issue has caused a regression #34419 @s-alves10 @situchan anyone of you can please confirm, thank you!

    Straight revert failing so not able to confirm. But I don't think so as this (still reproducible after reverting this change) was the actual fix and other codes are just revert of previous PR.

  18. melvin-bot
    assigned
    jliexpensify
    on Jan 17, 2024

  19. melvin-bot commented on Jan 17, 2024

    @melvin-bot
    melvin-botBot
    on Jan 17, 2024 – with Melvin Bot

    Issue is ready for payment but no BZ is assigned. @jliexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  20. melvin-bot commented on Jan 17, 2024

    @melvin-bot
    melvin-botBot
    on Jan 17, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    • ROLE: @s-alves10 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@jliexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  21. jliexpensify
    assigned
    situchan
    on Jan 17, 2024

  22. jliexpensify commented on Jan 17, 2024

    @jliexpensify
    jliexpensify
    on Jan 17, 2024
    Contributor

    @MonilBhavsar @tylerkaraszewski just to confirm, there's no regression here right?

    Here's a payment summary for everyone's review:

    Upworks Job

  23. situchan commented on Jan 18, 2024

    @situchan
    situchan
    on Jan 18, 2024
    Contributor

    are you meant to be hired or are you just reviewing the PR?

    This is follow-up (regression) of #31637.
    The work is done already and I reviewed 2nd PR. (I was not involved in first PR which caused this regression)
    @s-alves10's was already fully paid here for the work of first PR.

  24. jliexpensify commented on Jan 18, 2024

    @jliexpensify
    jliexpensify
    on Jan 18, 2024
    Contributor

    Oh hmm...so to clarify: I don't need to pay anyone?

  25. situchan commented on Jan 18, 2024

    @situchan
    situchan
    on Jan 18, 2024
    Contributor

    I am still eligible based on I was not involved in first PR which caused this regression

  26. jliexpensify commented on Jan 18, 2024

    @jliexpensify
    jliexpensify
    on Jan 18, 2024
    Contributor

    Thanks for clearing this up, I will withdraw the offer for Sangar and hire you @situchan

  27. jliexpensify commented on Jan 18, 2024

    @jliexpensify
    jliexpensify
    on Jan 18, 2024
    Contributor

    Paid and job closed.

  28. jliexpensify
    closed this as completedon Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions