[HOLD for payment 2024-01-26] [$500] Settings - Red dot remains after error is cleared

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31713

Action Performed:

Pre-requisite: user must be logged in

On staging, enable "Simulate failing network requests" in Settings > Preferences
Go to Settings > Profile > Contact method
Add a phone number as a new contact method
Wait for the pending add operation to fail
Once you see the red dot, click on the contact method and clear the error

Expected Result:

The red dot should disappear after the error is cleared

Actual Result:

The red dot remains on user avatar on the home screen and in settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6312254_1702503451411.bandicam_2023-12-13_15-07-14-733.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012ec660a67cb6d223
Upwork Job ID: 1735053356937179136
Last Price Increase: 2024-01-03
Automatic offers:

ntdiary | Reviewer | 28089273
tienifr | Contributor | 28089274

@michaelhaxhiu

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~012ec660a67cb6d223

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@ntdiary

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

All - Settings - Red dot remains after error is cleared

What is the root cause of that problem?

In deleteContactMethod, we are clearing errorFields.deletedLogin but we aren't clearing errorFields.addedLogin which is a part of the failureData of addNewContactMethodAndNavigate.

When we delete a contact method, we expect a green dot to show up while the deletion is being processed, this is added intentionally by using pendingFields.deletedLogin: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE as shown below in the code, however this green dot is override by red dot because of errorFields.addedLogin

App/src/libs/actions/User.js

Lines 186 to 200 in fe2d0d1

    
           function deleteContactMethod(contactMethod, loginList) { 
        
               const oldLoginData = loginList[contactMethod]; 
        
               const optimisticData = [ 
        
                   { 
        
                       onyxMethod: Onyx.METHOD.MERGE, 
        
                       key: ONYXKEYS.LOGIN_LIST, 
        
                       value: { 
        
                           [contactMethod]: { 
        
                               partnerUserID: '', 
        
                               errorFields: { 
        
                                   deletedLogin: null, 
        
                               }, 
        
                               pendingFields: { 
        
                                   deletedLogin: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

What changes do you think we should make in order to solve the problem?

We should clear that errorField on contact method deletion so the red dot doesn't show up during the deletion process

function deleteContactMethod(contactMethod, loginList) {
    ....
    value: {
        [contactMethod]: {
            ....
            errorFields: {
                deletedLogin: null,
                addedLogin: null,
            },

Result

Screen.Recording.2023-12-14.at.2.31.09.AM.mov

Proposal

Please re-state the problem that we are trying to solve in this issue.

Red dot remains after error is cleared when network connection is simulating slow network requests

What is the root cause of that problem?

The root cause of the problem is that in Contact Page there is an additional check which hides new contact requests with pendingAction "delete".

const hideChildren = shouldHideOnDelete && !isOffline && pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !hasErrors;

However, this check is missing from userUtils "hasLoginListError" function.

function hasLoginListError(loginList: Record<string, Login>): boolean {
    return Object.values(loginList).some((loginData) => Object.values(loginData.errorFields ?? {}).some((field) => Object.keys(field ?? {}).length > 0));
}

What changes do you think we should make in order to solve the problem?

Logic on both ends should be kept consistent so I would suggest we implement the same checks in userUtils and call it. This will maintain the DRY principle as well as is easier to maintain.

What alternative solutions did you explore? (Optional)

N/A

@sfurqan2

📣 @sfurqan2! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: sfurqan1999@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0163c31a5a31c72f3f

Hi! I just wanted to call it out here - I'm closing out #34758 as not a bug, but I'm pretty sure it means that QA was never able to successfully QA this issue. It would be great if y'all could make sure this works as expected on this issue!

@ntdiary

@ntdiary let's do the bugzero checklist here

@ntdiary

Next step is with @ntdiary to do the regression steps

@ntdiary

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Show all Expensify logins in Contact Methods page & view each in new Contact Method Details page #15204

[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15204/files#r1473781500

[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need

[@ntdiary] Determine if we should create a regression test for this bug. No need

[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need

[@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I think this is a small edge case we overlooked during the development of the contact details page, so it's okay to just leave a comment in the original PR, no regression test is needed. :)

@miljakljajic

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@miljakljajic

cc @miljakljajic can you please proceed with the payment on this issue? Thanks!

Paid and paid!

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-26] [$500] Settings - Red dot remains after error is cleared #33021

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

58 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function deleteContactMethod(contactMethod, loginList) {
	const oldLoginData = loginList[contactMethod];

	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.LOGIN_LIST,
	value: {
	[contactMethod]: {
	partnerUserID: '',
	errorFields: {
	deletedLogin: null,
	},
	pendingFields: {
	deletedLogin: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

[HOLD for payment 2024-01-26] [$500] Settings - Red dot remains after error is cleared #33021

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 13, 2023

melvin-bot commented on Dec 13, 2023

melvin-bot commented on Dec 13, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 13, 2023

AmjedNazzal commented on Dec 13, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

sfurqan2 commented on Dec 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Dec 14, 2023

sfurqan2 commented on Dec 14, 2023

58 remaining items

dangrous commented on Jan 29, 2024

danieldoglas commented on Jan 31, 2024

michaelhaxhiu commented on Jan 31, 2024

ntdiary commented on Feb 1, 2024

melvin-bot commented on Feb 1, 2024

danieldoglas commented on Feb 1, 2024

miljakljajic commented on Feb 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions