[HOLD for payment 2023-12-29] [$500] Request - When editing the IOU, the "Future Dates" are still locked

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Click on + > Request > Complete the manual request to any user (Note that HERE you can edit the "Date" to any future date as this is now expected and WAD)
4. After completing the request click on the IOU twice to get to the "Edit" screen.
5. Click on the "Date" in the IOU section to edit the date (The issue is here)

Expected Result:

User expects that if it is now intended that the user can send requests for Future dates, that he/she is able to edit future dates in this section as well

Actual Result:

In the edit IOU page, the user is unable to edit for future dates, the dates are locked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6312189_1702498700044.User_is_unable_to_edit_future_dates_in_the_IOU_edit_page_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01720f5c1caaa419d3
• Upwork Job ID: 1735034888322834432
• Last Price Increase: 2023-12-13
• Automatic offers:
• jjcoffee | Reviewer | 28060237
• DylanDylann | Contributor | 28060239

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01720f5c1caaa419d3

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request - When editing the IOU, the "Future Dates" are still locked

What is the root cause of that problem?

max date is now

App/src/pages/EditRequestCreatedPage.js

Lines 37 to 42 in 958c431

	<DatePicker
	inputID="created"
	label={translate('common.date')}
	defaultValue={defaultCreated}
	maxDate={new Date()}
	/>

What changes do you think we should make in order to solve the problem?

make max date after one year as we do here:

App/src/pages/iou/request/step/IOURequestStepDate.js

Lines 70 to 76 in b884e29

	<DatePicker
	inputID="moneyRequestCreated"
	label={translate('common.date')}
	defaultValue={transaction.created}
	maxDate={dateAdd(new Date(), {years: 1})}
	minDate={dateSubtract(new Date(), {years: 20})}
	/>

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the edit IOU page, the user is unable to edit for future dates, the dates are locked

What is the root cause of that problem?

In the edit date page, we are setting maxDate as now and aren't setting minDate

App/src/pages/EditRequestCreatedPage.js

Line 41 in b950c1e

maxDate={new Date()}

In the create date page, we are setting maxDate is after 1 year and minDate is before 20 years

App/src/pages/iou/request/step/IOURequestStepDate.js

Line 74 in b950c1e

maxDate={dateAdd(new Date(), {years: 1})}

It seems we allow editing dates to the future date in the request money flow as confirmed here

What changes do you think we should make in order to solve the problem?

App/src/pages/EditRequestCreatedPage.js

Line 41 in b950c1e

maxDate={new Date()}

In here we should update maxDate and minDate for consistency with the created date page

maxDate={dateAdd(new Date(), {years: 1})}
minDate={dateSubtract(new Date(), {years: 20})}

We also consider creating utils function or global variable for maxDate and minDate to dry code

What alternative solutions did you explore? (Optional)

NA

[jjcoffee]

Very similar proposals that both do the job, but I appreciate the extra attention to detail in @DylanDylann's proposal, particularly adding minDate too and the idea of DRYing up the code by adding a global variable. So let's go with @DylanDylann's proposal!

🎀👀🎀 C+ reviewed