Repository navigation
[HOLD for payment 2023-12-26] Room - Unable to leave public room #33010
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.This is the response for the
LeaveRoomcommand.
This is the response for the
LeaveRoomcommand on production
There seems no difference between the two responses, so the issue probably stem from the front end code change.
Let me if the action code has recently been changed -> https://expensify.slack.com/archives/C0593T50UHG/p1702500582444429
this might be coming from to #28730, its a big PR so i am still trying to get to exact root cause
Yes I already pinged @blazejkustra. Meanwhile if you find a root cause, please feel free to make a fix PR for this @ishpaul777.
Proposal
Please re-state the problem that we are trying to solve in this issue.
User is unable to leave the room. The room changes to Archived and back to normal
What is the root cause of that problem?
When we leave room, we don't set the
reportNamein optimistic data of reportApp/src/libs/actions/Report.ts
Line 2069 in e81ed8f
which makes
reconnectToReportAPI is called and then the data of the report is restore.
App/src/libs/actions/Report.ts
Line 1066 in e81ed8f
What changes do you think we should make in order to solve the problem?
- We should add
reportNamein the optimistic data of report here
App/src/libs/actions/Report.ts
Line 2069 in e81ed8f
or we should use
mergemethod, and only updatestatusNumandstateNum
2. To trigger navigating after leaving room, we should update statusNum, stateNum in successData{ ...Object.keys(report).reduce<Record<string, null>>((acc, key) => { acc[key] = null; return acc; }, {}), stateNum: CONST.REPORT.STATE_NUM.SUBMITTED, statusNum: CONST.REPORT.STATUS.CLOSED, }App/src/pages/home/ReportScreen.js
Line 316 in e81ed8f
Or we should remove this check from the condition because
reportIDstill present inoptimisticDataApp/src/pages/home/ReportScreen.js
Line 318 in e81ed8f
Or remove
reportIDfrom optimistic data here.
App/src/libs/actions/Report.ts
Line 2069 in e81ed8f
What alternative solutions did you explore? (Optional)
For point 2 in my proposal, we can remove this case in
ReportScreenand copy the navigate logic toleaveRoomfunctionApp/src/libs/actions/Report.ts
Line 2111 in e81ed8f
- We should add
@hayata-suenaga What about my proposal?
waiting for @blazejkustra
- added and removed
on Dec 14, 2023 1 remaining item
@hayata-suenaga @Julesssss Sorry for late response I finished work yesterday, here is a PR that should fix it. As this is a regression that originated from my TS migration PR, I fixed it without a proposal. If needed I can post one with more details, just let me know.
Reacted by JulesBecause the PR has been merged, I'll close this issue
- changed the title
[-] Room - Unable to leave public room[/-][+][HOLD for payment 2023-12-26] Room - Unable to leave public room[/+]on Dec 19, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Note that user is unable to leave the room
Expected Result:
User is able to leave the room
Actual Result:
User is unable to leave the room. The room changes to Archived and back to normal
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6312080_1702492440997.public_room.mp4
View all open jobs on GitHub