Repository navigation
[HOLD for payment 2024-02-07] [$500] Expense - Green dot does not appear in LHN when the request is created in workspace chat #32924
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.11-13
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to staging.new.expensify.com.
- Create a new workspace.
- Click FAB > Request money > Manual.
- Request money from a workspace chat.
- Note that the green dot appears in the workspace chat in LHN after the request is created.
- Create a new workspace.
- Go to the workspace chat > + > Request money.
- Create a manual expense in the workspace chat.
- Click on the expense preview to open report page.
- Return to the main chat.
Expected Result:
In Step 8. the green dot will appear next to workspace chat in LHN.
Actual Result:
In Step 8. the green dot does not appear next to the workspace chat in LHN, when the request is created in the workspace chat.
In Step 10, the green dot only appears after opening report page and returning to the main chat.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6310526_1702391036743.bandicam_2023-12-12_18-51-52-627__1_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~013b75f81794691835
- Upwork Job ID: 1734657794835312640
- Last Price Increase: 2023-12-19
- Automatic offers:
- getusha | Reviewer | 28066191
- tienifr | Contributor | 28066192
Activity
github-actions commentedon Dec 12, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 12, 2023
Triggered auto assignment to @nkuoch (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.shubham1206agra commentedon Dec 12, 2023
I am gonna investigate this one in the meantime
shubham1206agra commentedon Dec 12, 2023
I am unable to repro this. I am not seeing Green Dot Indicator in both cases
luacmartins commentedon Dec 12, 2023
I can't reproduce either, but I think that we should show the green dot. It shows up if you navigate to another report and then back to the workspace chat.
shubham1206agra commentedon Dec 12, 2023
True, but same behaviour is in prod I think. @kbecciv Can you confirm this?
luacmartins commentedon Dec 12, 2023
In prod the workspace chat just disappears from the LHN in focus mode lol
shubham1206agra commentedon Dec 12, 2023
Same in DEV
shubham1206agra commentedon Dec 12, 2023
In normal mode too
luacmartins commentedon Dec 12, 2023
Dev had the same behavior as staging for me
luacmartins commentedon Dec 12, 2023
I think we're missing
hasOutstandingChildRequestin the chat report57 remaining items
melvin-bot commentedon Jan 31, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 31, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 31, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
getusha commentedon Feb 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a looks like a case we missed that required Back-End changes.
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. Yes
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
dylanexpensify commentedon Feb 7, 2024
today!
dylanexpensify commentedon Feb 12, 2024
Payment summary:
dylanexpensify commentedon Feb 12, 2024
done!