Skip to content

[HOLD for payment 2024-01-25] [$500] Bank account - Missing white background when Plaid modal is rendering #32685

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.9.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to Settings > Workspaces > any workspace.
  3. Go to Bank account.
  4. Click Connect online with Plaid.

Expected Result:

When Plaid modal is rendering, a white background will appear with a spinner (PROD behavior).

Actual Result:

When Plaid modal is rendering, the background is transparent instead of white., which now looks like having two spinners on the same page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Staging

Bug6304618_1701964176410.20231207_063505.mp4

Production

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190435a1b9eb3175f
  • Upwork Job ID: 1732815115354394624
  • Last Price Increase: 2023-12-07
  • Automatic offers:
    • alitoshmatov | Reviewer | 28064602
    • tienifr | Contributor | 28064603
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. github-actions commented on Dec 7, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 7, 2023

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. neil-marcellini commented on Dec 7, 2023

    @neil-marcellini
    Contributor

    Taking a look 👀

  4. neil-marcellini commented on Dec 7, 2023

    @neil-marcellini
    Contributor

    Nothing really jumps out to me from the list of PRs in this release, but maybe the theme switching has to do with it. I'll do a little investigation locally now.

  5. neil-marcellini commented on Dec 7, 2023

    @neil-marcellini
    Contributor

    Shoot, I'm really not sure what's going on here. The view is rendered by react-plaid-link in an iframe. I was able to pause and inspect the page by setting a debugger below this line, but I haven't figure out the root cause. My guess is that we somehow broke this when changing some of the root styles of the app. I'll ask for help in the Slack open source channel.

    image

  6. neil-marcellini commented on Dec 7, 2023

    @neil-marcellini
    Contributor

    Posted in Slack here

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 7, 2023
  8. changed the title [-]Bank account - Missing white background when Plaid modal is rendering[/-] [+][$500] Bank account - Missing white background when Plaid modal is rendering[/+] on Dec 7, 2023
  9. 57 remaining items

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 7, 2024
  11. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

  12. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 7, 2024
  13. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  14. muttmuure commented on Feb 9, 2024

    @muttmuure
    Contributor

    Handling

  15. muttmuure commented on Feb 9, 2024

    @muttmuure
    Contributor

    Everyone is paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions