Repository navigation
[$500] Web - Incognito - If user returns from standby and unlocks incognito site, the app crashes #32680
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.9.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Access staging.new.expensify.com on Safari incognito
- Sign into a valid account
- Turn your computer on Standby (Sleep)
- Turn back on the screen and return to the Safari incognito page (It should be blocked and asking for a password to be entered to access incognito)
- Put the PC's password in and access the New Expensify site
Expected Result:
User expects the site to work normally
Actual Result:
On safari incognito, once returning, the site either crashes instantly or the LHN turns white and hides all information. On Prod I was not able to reproduce the crash and on PROD the LHN turns black and the user is no longer able to access this feature.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6304559_1701961253003.Crash_after_retruning_from_standyby_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0115544598250d08fd
- Upwork Job ID: 1732852742831104000
- Last Price Increase: 2024-01-04
Activity
github-actions commentedon Dec 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 7, 2023
Triggered auto assignment to @marcochavezf (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcochavezf commentedon Dec 7, 2023
I couldn't reproduce it on staging, just the LHN turned blank as happens in production:
Screen.Recording.2023-12-07.at.1.56.35.p.m.mov
I will remove the deploy blocker label
melvin-bot commentedon Dec 7, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)55 remaining items
melvin-bot commentedon Jan 8, 2024
@garrettmknight, @marcochavezf, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
dksingla commentedon Jan 8, 2024
@situchan would you please share feedback on my last comment? Thanks
situchan commentedon Jan 8, 2024
@dksingla I don't see the reason why LHN becomes blank in your RCA.
dksingla commentedon Jan 8, 2024
@situchan Can you please accept the solution for the crash? I am trying to find a solution for blank LHN as well.
garrettmknight commentedon Jan 11, 2024
@marcochavezf can you take this one on to either solve it yourself or help @dksingla move it forward?
marcochavezf commentedon Jan 12, 2024
@dksingla is the crashing issue still happening for you on staging? Because I tried to reproduce it but seems it's no longer reproducible there. The only outstanding issue would be the blank LHN in Safari incognito mode after returning from sleep mode (not happening in other browsers, also after interacting with the site the issue disappears):
Screen.Recording.2024-01-12.at.2.09.56.p.m.mov
@tienifr I think your proposal for the blank LHN has potential, but could you update it and provide more details about the solution?
marcochavezf commentedon Jan 15, 2024
Given the crash is no longer happening on staging and production, I think we should close this one and consider the blank LHN as a different issue.
marcochavezf commentedon Jan 16, 2024
I'm going to close it for now, but feel free to re-open or comment if you disagree
tienifr commentedon Jan 17, 2024
@marcochavezf should we create a new GH for the blank issue, or update the description of this GH to indicate it's for the blank issue?
The blank issue seems important to be fixed from an UX perspective.
situchan commentedon Jan 17, 2024
@marcochavezf how about creating separate GH for LHN blank issue? Or we can reuse this GH and just update OP