Repository navigation
[HOLD for payment 2023-12-29] [$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150% #32661
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @flodnv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Welp, I found another bug on production:
Edit: reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1701966565899779
I was not able to reproduce on my Pixel 6 on Chrome. I'm going to say this is not a blocker
Reacted by Sasha KlugerJob added to Upwork: https://www.upwork.com/jobs/~01485e3068c4913aa8
- changed the title
[-]IOU - Error message in Amount page overlaps with amount field when zoom level in 150%[/-][+][$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150%[/+]on Dec 7, 2023 33 remaining items
- changed the title
[-][$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150%[/-][+][HOLD for payment 2023-12-29] [$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150%[/+]on Dec 22, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-29. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
- @jjcoffee requires payment automatic offer (Reviewer)
- @FitseTLT requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
- [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@jjcoffee] Determine if we should create a regression test for this bug.
- [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- The PR that introduced the bug has been identified. Link to the PR: fix error message positioning on amount page #30287
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30287/files#r1439298027
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - hard one to catch
- Determine if we should create a regression test for this bug.
- If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
- Go to any chat > + > Request money
- Click Next without entering the amount
- Increase the zoom level to 150%
- Verify that the error message doesn't overlap with amount input
Do we agree 👍 or 👎
Reacted by Sasha KlugerThanks! I created the regression test issue and completed all payouts.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.9-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #32460
Action Performed:
Expected Result:
The error will not overlap with amount input field
Actual Result:
The error overlaps with amount input field
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6304456_1701955194737.RPReplay_Final1701906464.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit