You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list #32591
Version Number: 1.4.9-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
taking a look at the staging checklists but I don't think this needs to block future deploys, it's a style thing which can be handled with a follow up PR.
changed the title [-][HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/-][+][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/+]on Dec 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
github-actions commentedon Dec 6, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 6, 2023
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.bondydaa commentedon Dec 6, 2023
taking a look at the staging checklists but I don't think this needs to block future deploys, it's a style thing which can be handled with a follow up PR.
bondydaa commentedon Dec 6, 2023
hmm what makes you think that PR? I don't see that it touched anything with emojis or style sheets.
situchan commentedon Dec 6, 2023
@bondydaa this came from this removal
situchan commentedon Dec 6, 2023
I think we can demote this to NAB unless that offending PR caused any other regressions.
ZhenjaHorbach commentedon Dec 6, 2023
Oh )
Sorry ))
Not this regression ))
bondydaa commentedon Dec 6, 2023
yeah looks like we said we'd do a follow up PR to fix this #32259 (comment)
cc @grgia .
@situchan are you able to reproduce this? If so can you confirm if you're using windows? @parasharrajat same ❓ you a windows user? #32259 (review)
50 remaining items
[-][HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/-][+][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/+]melvin-bot commentedon Dec 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 21, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sakluger commentedon Dec 25, 2023
I'm offline this week, along with most of my team for the holidays. I'll handle payment as soon as I return on Jan 2.
parasharrajat commentedon Dec 26, 2023
No payment is required here. We are good to close.
sakluger commentedon Jan 3, 2024
Sounds good, closing.