Skip to content

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list #32591

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.9-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to any chat
  4. Enter any emoji code (e.g: 👋 , 😬 , 😄 , etc) or "@" for opens a list of user suggestions

Expected Result:

The scroll bar is grey

Actual Result:

The scroll bar is white

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

![Bug6303682_1701897642639!0612_1](https://github.com/Expensify/App/assets/78819774/7d08a23c-0386-49d0-8562-c8e5b6ff7939)

Bug6303682_1701897642637!image__186_

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c2daa05ba8f632d
  • Upwork Job ID: 1732790748658282496
  • Last Price Increase: 2023-12-07
  • Automatic offers:
    • shubham1206agra | Reviewer | 27999537

Activity

  1. github-actions commented on Dec 6, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 6, 2023

    @melvin-bot

    Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. bondydaa commented on Dec 6, 2023

    @bondydaa
    Contributor

    taking a look at the staging checklists but I don't think this needs to block future deploys, it's a style thing which can be handled with a follow up PR.

  4. bondydaa commented on Dec 6, 2023

    @bondydaa
    Contributor

    hmm what makes you think that PR? I don't see that it touched anything with emojis or style sheets.

  5. situchan commented on Dec 6, 2023

    @situchan
    Contributor

    @bondydaa this came from this removal

  6. situchan commented on Dec 6, 2023

    @situchan
    Contributor

    I think we can demote this to NAB unless that offending PR caused any other regressions.

  7. ZhenjaHorbach commented on Dec 6, 2023

    @ZhenjaHorbach
    Contributor

    Oh )
    Sorry ))
    Not this regression ))

  8. bondydaa commented on Dec 6, 2023

    @bondydaa
    Contributor

    yeah looks like we said we'd do a follow up PR to fix this #32259 (comment)

    cc @grgia .

    @situchan are you able to reproduce this? If so can you confirm if you're using windows? @parasharrajat same ❓ you a windows user? #32259 (review)

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 6, 2023
  10. 50 remaining items

  11. changed the title [-][HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/-] [+][HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [HOLD #32672] [Theme Switching] 🐛 Web - Chat - The scroll bar is white in the emoji suggestion list[/+] on Dec 21, 2023
  12. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-28. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. added and removed on Dec 25, 2023
  15. sakluger commented on Dec 25, 2023

    @sakluger
    Contributor

    I'm offline this week, along with most of my team for the holidays. I'll handle payment as soon as I return on Jan 2.

  16. parasharrajat commented on Dec 26, 2023

    @parasharrajat
    Member

    No payment is required here. We are good to close.

  17. sakluger commented on Jan 3, 2024

    @sakluger
    Contributor

    Sounds good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions