[HOLD for payment 2024-01-04] [$500] Merchant line on preview card is using wrong text size

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.7.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391780917959

Action Performed:

Submit a request on a workspace

Expected Result:

In the preview card of both the workspace chat and the expense report, the merchant line should be in our normal font size which is 15px. The bottom of the receipt should also be rounded.

Actual Result:

The font size for the merchant is too small, at 13px. The bottom of the receipt is not rounded

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a6a405785ccbd170
Upwork Job ID: 1731337099034644480
Last Price Increase: 2023-12-03
Automatic offers:

0xmiroslav | Reviewer | 28062368
mkhutornyi | Contributor | 28062369

Job added to Upwork: https://www.upwork.com/jobs/~01a6a405785ccbd170

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@0xmiroslav

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant line on preview card is using wrong text size

What is the root cause of that problem?

we are using textLabelSupporting which uses - fontSizeLabel here at

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 329 in 1682be4

    
           <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>

For radius we have not applied border radius for bottom side of image in reportActionItemImages styles.

What changes do you think we should make in order to solve the problem?

We should use fontSizeNormal instead of that, here -

App/src/styles/styles.ts

Lines 1138 to 1142 in 1682be4

    
           textLabelSupporting: { 
        
               fontFamily: fontFamily.EXP_NEUE, 
        
               fontSize: variables.fontSizeLabel, 
        
               color: theme.textSupporting, 
        
           },

But textLabelSupporting is being used at many places, so we shall avoid changing that, instead we can create a new style for merchant or add the style in styles prop.

For border radius -
We shall remove the borderTopLeftRadius and borderTopRightRadius and apply borderRadius styles with variables.componentBorderRadiusLarge

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant line on preview card is using wrong text size and the bottom of the receipt is not rounded

What is the root cause of that problem?

We use other styles for merchant text in MoneyRequestPreview(Font size) and for ReportActionItemImages (Border radius)

What changes do you think we should make in order to solve the problem?

Pass on extra style here (The font size for the merchant is too small, at 13px)

styles.textNormal

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 329 in 1682be4

    
           <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20, styles.breakWord]}>

Or change styles here

fontSize: variables.fontSizeNormal,

App/src/styles/styles.ts

Line 1140 in 1682be4

fontSize: variables.fontSizeLabel,

Update styles here (The bottom of the receipt is not rounded)

borderRadius: variables.componentBorderRadiusLarge,

App/src/styles/styles.ts

Lines 3710 to 3711 in 1682be4

    
           borderTopLeftRadius: variables.componentBorderRadiusLarge, 
        
           borderTopRightRadius: variables.componentBorderRadiusLarge,

What alternative solutions did you explore? (Optional)

NA

@BhuvaneshPatil

@BhuvaneshPatil
add comment that your proposal for updating border was later than my proposal)

I was typing that when your proposal was posted.

@0xmiroslav

@0xmiroslav can you complete the checklist please?

@0xmiroslav

@0xmiroslav Friendly bump! Basically so we can complete the payments

No PR caused regression.
This is just minor design improvement.

Regression Test Proposal

Submit 2 requests (one for manual, one for scan) on any workspace
Observe preview card in workspace chat
Verify that receipt image is rounded in all 4 corners
Verify that "2 requests" text has 15px font size
Go to expense report
Verify that receipt image is rounded in all 4 corners
Verify that merchant line text has 15px font size

I am not sure regression test is needed here as this will change again in #33979

@mkhutornyi

@mkhutornyi payment sent and contract ended - thank you! 🎉

@0xmiroslav

@0xmiroslav you provided a regression test proposal but then also state that a regression test is not needed?

Also, are we still in the process of holding your payments? Do you not have your Upwork profile sorted yet?

I provided regression test in case anyone disagrees skipping it.
No issue with my upwork but still holding my payment.
Let's close this for now if everything else is set.

@0xmiroslav

Thanks @0xmiroslav

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-04] [$500] Merchant line on preview card is using wrong text size #32415

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	textLabelSupporting: {
	fontFamily: fontFamily.EXP_NEUE,
	fontSize: variables.fontSizeLabel,
	color: theme.textSupporting,
	},

	borderTopLeftRadius: variables.componentBorderRadiusLarge,
	borderTopRightRadius: variables.componentBorderRadiusLarge,

[HOLD for payment 2024-01-04] [$500] Merchant line on preview card is using wrong text size #32415

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 3, 2023

melvin-bot commented on Dec 3, 2023

melvin-bot commented on Dec 3, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 3, 2023

BhuvaneshPatil commented on Dec 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented on Dec 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented on Dec 3, 2023

BhuvaneshPatil commented on Dec 3, 2023

50 remaining items

abekkala commented on Jan 4, 2024

pecanoro commented on Jan 8, 2024

0xmiroslav commented on Jan 8, 2024

Regression Test Proposal

abekkala commented on Jan 8, 2024

abekkala commented on Jan 8, 2024

0xmiroslav commented on Jan 8, 2024

abekkala commented on Jan 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions