[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Login to ND Expensify
Press CTRL+K or click Magnifying glass icon
Select any dropdown item with Tab key
Press Enter key

Expected Result:

Items in search dropdown should be selected consistently both with up&down and tab keys, and the correct one is opened after pressing Enter key

Actual Result:

Highlighted item (default first one) with Up&Down keys is opened instead of blue bordered item which is selected with Tab key

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6297806_1701459856402.2023-12-01_20-58-59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015640f29df912d30c
Upwork Job ID: 1730709594365632512
Last Price Increase: 2023-12-01
Automatic offers:

alitoshmatov | Reviewer | 28062509
DylanDylann | Contributor | 28062510

Job added to Upwork: https://www.upwork.com/jobs/~015640f29df912d30c

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alitoshmatov

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Highlighted item (default first one) with Up&Down keys is opened instead of blue bordered item which is selected with Tab key

What is the root cause of that problem?

The root cause is that the pressOnEnter is set on Confirm button and it's priority is 1 so when we click enter, the button is pressed first with highlighted item.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 656 to 662 in 414c08c

    
           <Button 
        
               success 
        
               style={[this.props.themeStyles.w100]} 
        
               text={defaultConfirmButtonText} 
        
               onPress={this.props.onConfirmSelection} 
        
               pressOnEnter 
        
               enterKeyEventListenerPriority={1}

What changes do you think we should make in order to solve the problem?

we need to adjust button's priority here or can change the default item when we select other item using tab.

What alternative solutions did you explore? (Optional)

N/A

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Search - Selected dropdown item with tab key is not opened in Search

What is the root cause of that problem?

We're selecting the row based on highlighted item, and we don't consider the blue focus one

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 302 to 325 in 1682be4

    
           selectFocusedOption() { 
        
               const focusedOption = this.state.allOptions[this.state.focusedIndex]; 
        
               if (!focusedOption || !this.props.isFocused) { 
        
                   return; 
        
               } 
        
               if (this.props.canSelectMultipleOptions) { 
        
                   this.selectRow(focusedOption); 
        
               } else if (!this.state.shouldDisableRowSelection) { 
        
                   this.setState({shouldDisableRowSelection: true}); 
        
                   let result = this.selectRow(focusedOption); 
        
                   if (!(result instanceof Promise)) { 
        
                       result = Promise.resolve(); 
        
                   } 
        
                   setTimeout(() => { 
        
                       result.finally(() => { 
        
                           this.setState({shouldDisableRowSelection: false}); 
        
                       }); 
        
                   }, 500); 
        
               } 
        
           }

What changes do you think we should make in order to solve the problem?

The idea to solve this bug was approved by C+ and internal in other issue. fix: 31635 the blue focus is not prioritized over the application highlight #32252
Generally, we need to change the logic that we use to get focusedOption:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 303 in 1682be4

const focusedOption = this.state.allOptions[this.state.focusedIndex];
Now, it only based on the this.state.focusedIndex, so if there is another option is select by tab key, we will not consider it.
To implement the above idea:

Passing additional prop named keyForList to OptionRow. It will become to:

            <OptionRow
                keyForList={item.keyForList}

Then, pass the above keyForList props to PressableWithFeedback
It will become to:

                    <PressableWithFeedback
                        testID={props.keyForList}

Finally, update the logic to get the focusedOption in here:

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 303 in 1682be4

const focusedOption = this.state.allOptions[this.state.focusedIndex];

It will become to:

const focusedItemKey = lodashGet(e, ['target', 'attributes', 'data-testid', 'value']);
        const focusedOption = focusedItemKey ? _.find(this.state.allOptions, (option) => option.keyForList === focusedItemKey) : this.state.allOptions[this.state.focusedIndex];

What alternative solutions did you explore? (Optional)

NA

@alitoshmatov

@alitoshmatov please keep us posted if any of the proposals will fix this issue. Thanks!

@alitoshmatov

@alitoshmatov or @deetergp - can you please help confirm if this PR did cause regression? Thanks!

@alexpensify

Based on my observation, our PR didn't directly cause this regression, the regression didn't occur after merging our PR. However our solution was based on faulty approach which was already implemented by #32252. We took this solution for granted and followed the same approach. Finally #33491 PR caused the regression which broke our faulty solution. I am okay if penalty is applied to my payment, since I should have been more cautious on my review.

cc: @alexpensify, @deetergp, @Beamanator (since you worked on fixing the regression)

@alitoshmatov

Thank you @alitoshmatov for this update. @Beamanator and @deetergp can I get some feedback here regarding this payment? Thanks!

@deetergp

@deetergp, @alexpensify, @alitoshmatov, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@deetergp

Bumping - @deetergp and @Beamanator can I get your feedback here?

@alitoshmatov

I agree with @alitoshmatov 's summary here: #32388 (comment)

The PR for this issue (Fix: focusing on item by tab key does not work #33265) was merged 3 weeks ago
The PR which technically caused the regression was [NoQA] add perf tests to OptionsSelector #33491, which was merged 2 weeks ago

While the PR for this issue and this one were a bit iffy & weren't perfect, they didn't cause the regressions so I don't believe payment here should have the penalty applied

Thanks, I'll work on the payment process tomorrow.

Closing - I updated the summary here: #32388 (comment)

Everyone has been paid via Upwork and I closed that job.

Navigation Menu

Repository navigation

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

42 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Button
	success
	style={[this.props.themeStyles.w100]}
	text={defaultConfirmButtonText}
	onPress={this.props.onConfirmSelection}
	pressOnEnter
	enterKeyEventListenerPriority={1}

	selectFocusedOption() {
	const focusedOption = this.state.allOptions[this.state.focusedIndex];

	if (!focusedOption \|\| !this.props.isFocused) {
	return;
	}

	if (this.props.canSelectMultipleOptions) {
	this.selectRow(focusedOption);
	} else if (!this.state.shouldDisableRowSelection) {
	this.setState({shouldDisableRowSelection: true});

	let result = this.selectRow(focusedOption);
	if (!(result instanceof Promise)) {
	result = Promise.resolve();
	}

	setTimeout(() => {
	result.finally(() => {
	this.setState({shouldDisableRowSelection: false});
	});
	}, 500);
	}
	}

[HOLD for payment 2024-01-02] [$500] Web - Search - Selected dropdown item with tab key is not opened in Search #32388

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Dec 1, 2023

melvin-bot commented on Dec 1, 2023

melvin-bot commented on Dec 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Dec 1, 2023

unidev727 commented on Dec 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DylanDylann commented on Dec 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented on Dec 4, 2023

42 remaining items

alexpensify commented on Jan 3, 2024

alitoshmatov commented on Jan 4, 2024

alexpensify commented on Jan 5, 2024

melvin-bot commented on Jan 8, 2024

alexpensify commented on Jan 8, 2024

Beamanator commented on Jan 10, 2024

alexpensify commented on Jan 11, 2024

alexpensify commented on Jan 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions