Skip to content

[$500] Private notes - Note editor opens instead of list for user with existing private notes #32302

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.6-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31344

Action Performed:

Precondition: There is a chat with some content in the Privates notes and the note is not visited before. If visited, please log out and log in again

  1. Go to staging.new.expensify.com
  2. Open the chat from the precondition
  3. Click on the header
  4. Click Private notes

Expected Result:

User is navigated to private note list screen

Actual Result:

User is navigated to private note editor instead of private note list screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296532_1701375305114.bandicam_2023-12-01_02-53-05-577__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b1540c07c23a34c8
  • Upwork Job ID: 1730368222515441664
  • Last Price Increase: 2023-11-30

Activity

  1. github-actions commented on Nov 30, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 30, 2023

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. chiragsalian commented on Nov 30, 2023

    @chiragsalian
    Contributor

    @lanitochka17, can you elaborate what you mean by this,

    Open the chat from the precondition

    what do you mean by precondition?

    Also i tested the private notes on a DM and a group chat and it seemed to work fine for me on staging chrome. Can you double check?
    Meanwhile I'll ping the authors of #31344 to double check as well.

  4. chiragsalian commented on Nov 30, 2023

    @chiragsalian
    Contributor

    Asked authors in slack here
    Asked QA here.

    image

    I don't see any issue so I've asked others to confirm. If the issue does infact persist we can revert #31344 but i'd like to confirm it first before reverting.

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 30, 2023
  6. chiragsalian commented on Nov 30, 2023

    @chiragsalian
    Contributor

    As discussed here, not a blocker.

    Assigning @DylanDylann and @ArekChr to follow up with a fix as early as possible.
    If it helps, i was able to reproduce the issue by logging out, logging in and then clicking on an existing private notes. Then i see the editor instead of the list. For me this happens just once and then its fine until i log out and log in again. Please check and implement a fix.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 30, 2023
  8. changed the title [-]Private notes - Note editor opens instead of list for user with existing private notes[/-] [+][$500] Private notes - Note editor opens instead of list for user with existing private notes[/+] on Nov 30, 2023
  9. 16 remaining items

  10. DylanDylann commented on Dec 26, 2023

    @DylanDylann
    Contributor

    @jjcoffee Can you help check this one #32302 (comment) once you have a chance

  11. mvtglobally commented on Dec 31, 2023

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  12. jjcoffee commented on Jan 2, 2024

    @jjcoffee
    Contributor

    @DylanDylann I'm not sure I fully understand your comment or if you are proposing a particular solution, but I think it's up to the C+ on this issue to handle regressions. cc @ArekChr

  13. DylanDylann commented on Jan 11, 2024

    @DylanDylann
    Contributor

    @jjcoffee Maybe @ArekChr is not available at this time

  14. ArekChr commented on Jan 12, 2024

    @ArekChr
    Contributor

    Hey, sorry for the late reply. I wanted to let you know that I'm no longer in the C+ role, as I've moved to the Waves team. Could you please assign a new C+ to take over here? Thanks!

  15. shubham1206agra commented on Mar 11, 2024

    @shubham1206agra
    Contributor

    @mallenexpensify This seems to require a new C+ for some time, and Overdue was not applied here due to the Reviewing label. Can QA retest #32302 (comment) and maybe we can open this for External contributors? I am happy to volunteer for C+ position here.

  16. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    @chiragsalian, @ArekChr, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  17. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    and removed
    ReviewingHas a PR in review
    on Mar 13, 2024
  18. mallenexpensify commented on Mar 13, 2024

    @mallenexpensify
    Contributor

    QA, for retesting, here's a vid example
    #32302 (comment)

    @shubham1206agra , yes, I'll assign you as C+ if the bug persists after more testing. Did you try to reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions