[$500] BA - No validation error when emoji and certain symbols are entered in name field

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30674

Action Performed:

Navigate to staging.new.expensify.com
Go to Settings > Workspaces > any workspace
Go to Bank account > Connect manually
Proceed to Step 3
Add @, +, (), [] and emoji in the name field
Submit the form

Expected Result:

Error will show up on the name field with invalid symbols and emoji

Actual Result:

Error does not show up on the name field with invalid symbols and emoji. Only certain symbols pass the validation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6296280_1701365098247.20231130_214539.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fdad690a07b3c07f
Upwork Job ID: 1740328309374783488
Last Price Increase: 2024-01-10
Automatic offers:

0xmiroslav | Reviewer | 28109979
Krishna2323 | Contributor | 28109980

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Regression from linked PR

Not regression. This validation was never happened before #30674.
Btw, happy to take this as C+

Proposal

Please re-state the problem that we are trying to solve in this issue.

BA - No validation error when emoji and certain symbols are entered in name field.

What is the root cause of that problem?

We only check validation to determine if the name is empty, there is no validation in place to ensure that the name contains only Latin characters.

What changes do you think we should make in order to solve the problem?

We should add an 'if' statement to check whether the name contains only valid firstName & lastName or not. We can use the new function isValidPersonName inside ValidationUtils.

App/src/libs/ValidationUtils.ts

Lines 303 to 305 in 1682be4

    
           function isValidPersonName(value: string) { 
        
               return /^[^\d^!#$%*=<>;{}"]+$/.test(value); 
        
           }

Updated code should look like:

    // Inside `validate` function in `RequestorStep.js`
    if (!ValidationUtils.isValidPersonName(values.firstName)) {
        errors.firstName = 'bankAccount.error.firstName';
    }

    if (!ValidationUtils.isValidPersonName(values.lastName)) {
        errors.lastName = 'bankAccount.error.lastName';
    }

Result

What alternative solutions did you explore? (Optional)

Or we can use isValidLegalName instead of isValidPersonName which only permits Latin characters.

App/src/libs/ValidationUtils.ts

Lines 326 to 329 in 50865ef

    
           function isValidLegalName(name: string): boolean { 
        
               const hasAccentedChars = Boolean(name.match(CONST.REGEX.ACCENT_LATIN_CHARS)); 
        
               return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name) && !hasAccentedChars; 
        
           }

@stitesExpensify

We only check validation to determine if the name is empty, there is no validation in place to ensure that the name contains only Latin characters.

So looking at the linked PR we explicitly decided not to exclude special characters in the name field as per here. It's unclear if that matched Onfido's requirements or not? CC: @stitesExpensify as you reviewed that PR as well.

@0xmiroslav assigning you for the time being.

We don't check for onfido's requirements on the front end or back end currently. I posted the backend logic on the other issue and we just strip out a specific set of characters. This seems like a nice to have, but honestly if you're putting random random characters and emojis in your name and it fails, I'm not too concerned by that.

If we want to add @ or + we can, but I'm not aware of any full list of forbidden characters that we have anywhere

Raising PR today.

@Ollyws

@Ollyws PR ready for review :)

PR hit staging 15 hours ago.

@NikkiWines

@NikkiWines friendly bump for payments here :), PR was deployed to production on 29th Feb.

@trjExpensify

@trjExpensify can you issue payment, please? Thank you 🙇

@Krishna2323

Payment summary:

@Krishna2323 paid $500 for the fix
@Ollyws offer sent for $500 for the review

Accepted, thanks.

Paid, closing. Thanks, everyone!

Navigation Menu

Repository navigation

[$500] BA - No validation error when emoji and certain symbols are entered in name field #32291

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

121 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function isValidPersonName(value: string) {
	return /^[^\d^!#$%*=<>;{}"]+$/.test(value);
	}

	function isValidLegalName(name: string): boolean {
	const hasAccentedChars = Boolean(name.match(CONST.REGEX.ACCENT_LATIN_CHARS));
	return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name) && !hasAccentedChars;
	}

[$500] BA - No validation error when emoji and certain symbols are entered in name field #32291

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 30, 2023

melvin-bot commented on Nov 30, 2023

Bug0 Triage Checklist (Main S/O)

shubham1206agra commented on Nov 30, 2023

0xmiroslav commented on Dec 3, 2023

Krishna2323 commented on Dec 3, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

trjExpensify commented on Dec 4, 2023

stitesExpensify commented on Dec 4, 2023

stitesExpensify commented on Dec 4, 2023

121 remaining items

Krishna2323 commented on Feb 21, 2024

Krishna2323 commented on Feb 21, 2024

trjExpensify commented on Feb 27, 2024

Krishna2323 commented on Mar 8, 2024

NikkiWines commented on Mar 8, 2024

trjExpensify commented on Mar 11, 2024

Ollyws commented on Mar 11, 2024

trjExpensify commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions