Skip to content

[$500] Web - Hmm... it's not here page displayed after clicking on the card transaction preview #32155

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #31353
Version Number: 1.4.4-3
Reproducible in staging?: y
Reproducible in production?: not able to check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: an account with the expensify card and transactions on that card

  1. In OldDot, login into the account
  2. Navigate to the report that contains the Expensify card transactions
  3. Copy the reportID shown in the URL
  4. In NewDot, navigate to /r/ where reportID is the reportID copied in step 3
  5. Click on the card transaction preview

Expected Result:

The transaction preview is displayed

Actual Result:

Hmm... it's not here page displayed after clicking on the card transaction preview

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293918_1701208556496.Recording__5571.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01da767971b05ba1f7
  • Upwork Job ID: 1729632742876860416
  • Last Price Increase: 2023-11-28

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 28, 2023
  2. changed the title [-]Web - Hmm... it's not here page displayed after clicking on the card transaction preview[/-] [+][$500] Web - Hmm... it's not here page displayed after clicking on the card transaction preview[/+] on Nov 28, 2023
  3. melvin-bot commented on Nov 28, 2023

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Nov 28, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 28, 2023
  6. melvin-bot commented on Nov 28, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Nov 28, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  8. junsuparkswe commented on Nov 29, 2023

    @junsuparkswe

    Is there a way to create fake card transactions so I can try to reproduce this bug?

  9. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    📣 @junsupark94! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  10. junsuparkswe commented on Nov 29, 2023

    @junsuparkswe

    Contributor details
    Your Expensify account email: junsupark94@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01f0918c3cf48c22cd

  11. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. 8 remaining items

  13. luacmartins commented on Dec 1, 2023

    @luacmartins
    Contributor

    Do you mean card transactions? From the OP this seems like a backwards compatibility issue, since it doesn't seem like we fetched those, we are manually navigating to a report we can only see in OldDot. As far as the migration for backwards compatibility goes, we deemed it out of the scope in the design doc so this is not done and expected, but maybe now is the time to do it?

    We also have some backwards compatibility concerns here, since existing company card transactions don’t have a corresponding Workspace chat, ReportPreview action, IOU reportAction and existing company card transactions would need to be migrated. However, this was considered out of scope for Money 20/20 deadline and would be tackled as a phase 2 part of the project.

  14. garrettmknight commented on Dec 4, 2023

    @garrettmknight
    Contributor

    @grgia do you think this is worth prioritizing now?

  15. grgia commented on Dec 5, 2023

    @grgia
    Contributor

    From the OP this seems like a backwards compatibility issue, since it doesn't seem like we fetched those, we are manually navigating to a report we can only see in OldDot.

    @luacmartins but if the transaction exists in NewDot, then during the create transaction flow we should be creating the report in NewDot too shouldn't we?

  16. grgia commented on Dec 5, 2023

    @grgia
    Contributor

    @garrettmknight TBD, I think if this pertains to old reports only, then no. But if it's a problem with our core transaction creation logic then yes- though we should try to do specific internal testing of this flow with real card transactions and reports before we work on this bug

  17. luacmartins commented on Dec 5, 2023

    @luacmartins
    Contributor

    @luacmartins but if the transaction exists in NewDot, then during the create transaction flow we should be creating the report in NewDot too shouldn't we?

    Yes, I read the OP wrong 😓 So the transactions do show up in NewDot but it seems like we have an issue opening the transaction thread. I couldn't reproduce the issue locally and the logs for reportID 2966681377842678 used in the video don't show any errors.

    @kavimuru could you please retest this and provide a video?

  18. melvin-bot commented on Dec 8, 2023

    @melvin-bot

    @garrettmknight, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  19. kavimuru commented on Dec 8, 2023

    @kavimuru
    Author

    @kavimuru could you please retest this and provide a video?

    @luacmartins Sure will do!

  20. kavimuru commented on Dec 8, 2023

    @kavimuru
    Author

    @luacmartins Retested and fixed now.

    Recording.5660.mp4
  21. self-assigned this
    on Dec 8, 2023
  22. luacmartins commented on Dec 8, 2023

    @luacmartins
    Contributor

    Cool, I think we're good to close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions