Repository navigation
[HOLD for payment 2024-01-22] [$500] iOS - Attachment - The image shakes when you zoom in and back to the original size #32110
Description
Activity
- changed the title
[-]iOS - Attachment - The image shakes when you zoom in and back to the original size[/-][+][$500] iOS - Attachment - The image shakes when you zoom in and back to the original size[/+]on Nov 28, 2023 Job added to Upwork: https://www.upwork.com/jobs/~01a3b2c6d67f8d66f1
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)I agree that this is an annoying bug that we should solve. Let's see if any contributors can figure out what's going on and how to fix it.
Debugging observations:
- in order to debug this one needs to be able to run the iOS app on a real device
- the issue's RC comes from the
ImageTransformer.jsimplementation of pan / pinch gestures which are both active simultaneously and the conflict between the 2 is not handled - it seems like while pinch zooming, when 1 of the 2 pointers (fingers) is lifted up, the image jumps and centers to the anchor of the 1 remaining pointer - when this happens fast like in the issue's video, we get that image shake
Considering all these findings, I was still not able to find a fix yet.
Maybe @chrispader can chime in with some pointers as to a possible fix for this issue since he's the author of
ImageTransformer's implementation and I am sure he's more familiar with gestures and the way they work together.55 remaining items
- changed the title
[-][$500] iOS - Attachment - The image shakes when you zoom in and back to the original size[/-][+][HOLD for payment 2024-01-22] [$500] iOS - Attachment - The image shakes when you zoom in and back to the original size[/+]on Jan 15, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-22. 🎊
For reference, here are some details about the assignees on this issue:
- @chrispader does not require payment (Contractor)
- @mollfpr requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
- [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@mollfpr] Determine if we should create a regression test for this bug.
- [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment Summary
- Contributor: @chrispader is from an agency-contributor and not due payment
- C+: @mollfpr payable $500 via Manual Request
BugZero Checklist (@sakluger)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1729484843894013952/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:I couldn't find the offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be good.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- Go to a report with image attachments
- Open an image
- Pinch to zoom in and slightly move both fingers in some direction (top/right/bottom/left)
- Release pinch gesture
- Verify the image is not flickers/shakes
- 👍 or 👎
Thanks! Updated the payment summary here: #32110 (comment). @mollfpr feel free to submit the manual request for payment.
Reacted by Mohammad Luthfi Fathur Rahman@sakluger @mountiny Be sure to fill out the Contact List!
$500 payment for @mollfpr based on payment summary.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The image should zoom smoothly without shaking.
Actual Result:
The image shakes when you zoom in a little and when you zoom back to the original size.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6293079_1701173093223.Jfaf8028.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit