Repository navigation
[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question #32104
Description
Activity
- changed the title
[-]Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-][+][$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+]on Nov 28, 2023 Job added to Upwork: https://www.upwork.com/jobs/~01645371315accf60d
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)31 remaining items
- changed the title
[-][HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-][+][HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+]on Nov 30, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
- [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
- [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/-][+][HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] [$500] Web-No error message if press Save&Continue without fill anything in 2 & next idology question[/+]on Dec 1, 2023 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@madmax330 / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
- [@madmax330 / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@madmax330 / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@madmax330 / @luacmartins] Determine if we should create a regression test for this bug.
- [@madmax330 / @luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when executing PR: #31401
Version Number: v1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Expected Result:
Errors should appear when pressing Save&Continue without filling anything in all idology questions
Actual Result:
No error message when press Save&Continue without filling anything in 2 and next idology question
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6292867_1701162387966.bandicam_2023-11-28_10-54-49-442.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit