Repository navigation
[HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] IOU - Clicking on card and amount does not cause any action #32077
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Tap show more and note "card" option is not displayed
Was this a new feature? What is the "card" option?
Tapping on card must trigger an action or card option should not be displayed
also, what is "action"?
Ohhh you are saying that this should not be here? Got it.
I'd probably phrase this like:
"Card" option row appears in request detail for regular non-Card expense
Ah we are returning the cash card for the
cardID. We will want to make sure that gets omitted and never returned with the report's transactions maybe?cc @luacmartins I think probably we want to check if the card is "cash" in Auth at some point
We can revert @grgia's PR here for now to fix the blocker.
Unless there are any other ideas?
This is a new feature, so I think it'd be ok to demote that to NAB since it doesn't really break any functionality (the option just shouldn't be there) and we can work on an Auth PR to filter those cards out. What do you think?
It's a core flow so I'll raise a PR to hide the row for everyone temporarily. My preference would be to avoid shipping the broken code.
42 remaining items
@anmurali, @grgia, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.
@anmurali, @grgia, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.
@anmurali, @grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Offer is https://www.upwork.com/nx/wm/offer/100368742
Pls let me know if the amount is right.Can't access upwork job
Paid!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Tapping on card must trigger an action or card option should not be displayed
Actual Result:
In manual request IOU detail page, tapping on "card" does not trigger any action
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6292395_1701121963215.oip.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmurali