[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Workspace - Workspace name misalignment below room name

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to Settings > Workspaces > New Workspace > Settings
Change the workspace name and save it
Now go to the "announce" or "admin" room
Click on the room header
Notice the workspace name is not centered below the room name

Expected Result:

The workspace name should be centered, as it is in production

Actual Result:

The workspace name is not centered below the room name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Uploading Bug6289372_1700822031565!2023-11-24_15-21-05.mp4…

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@AndrewGable

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Production:

Gravar.540.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace name misalignment below room name

What is the root cause of that problem?

We don't set styles.textAlignCenter in the subtitle of DetailPage

What changes do you think we should make in order to solve the problem?

In here

App/src/pages/ReportDetailsPage.js

Line 160 in d985a0e

    
           textStyles={[styles.sidebarLinkText, styles.textLabelSupporting, styles.pre, styles.mt1]}

Add styles.textAlignCenter

What alternative solutions did you explore? (Optional)

@saranshbalyan-1234

Regression from #31516
cc: @saranshbalyan-1234

@saranshbalyan-1234

Regression from #31516

cc: @saranshbalyan-1234

Sure, Will raise a PR tomorrow :)

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Fixed

@saranshbalyan-1234

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression in workspace name #31880

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@saranshbalyan-1234 requires payment

@saranshbalyan-1234

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix regression in workspace name #31880

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@saranshbalyan-1234 requires payment

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Workspace - Workspace name misalignment below room name #31867

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Workspace - Workspace name misalignment below room name #31867

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Nov 25, 2023

melvin-bot commented on Nov 25, 2023

melvin-bot commented on Nov 25, 2023

lanitochka17 commented on Nov 25, 2023

DylanDylann commented on Nov 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

situchan commented on Nov 25, 2023

saranshbalyan-1234 commented on Nov 25, 2023

melvin-bot commented on Nov 25, 2023

mountiny commented on Nov 27, 2023

melvin-bot commented on Nov 27, 2023

melvin-bot commented on Nov 29, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions