Skip to content

[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid #31844

Closed
Closed
[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid#31844
Assignees
luacmartins
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Description

@kbecciv
kbecciv
opened on Nov 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.4.2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31061

Action Performed:

  1. Create a workspace in admin and invite a member
  2. In member account , Global Create > Request Money > $50 > choose the workspace > confirm
  3. As a admin navigate to the expenseReport view
  4. Click Pay elsewhere green button at the top right of the report
  5. Observe the system message added to the expenseReport
  6. Login to member account and observe the LHN preview

Expected Result:

paid action preview (requestor viewer)
"Workspace" paid $50.00
"Admin" : paid $50.00 elsewhere

Actual Result:

LHN preview is
"Workspace" paid $50.00
Requested $50.00 until clicking on it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6289674_1700844293684.Recording__262.mp4

View all open jobs on GitHub

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 24, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Nov 24, 2023

  3. github-actions commented on Nov 24, 2023

    @github-actions
    github-actionsBot
    on Nov 24, 2023 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    luacmartins
    on Nov 24, 2023

  5. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  6. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. luacmartins commented on Nov 24, 2023

    @luacmartins
    luacmartins
    on Nov 24, 2023
    Contributor

    Likely a regression from #31061. cc @koko57

  8. luacmartins commented on Nov 24, 2023

    @luacmartins
    luacmartins
    on Nov 24, 2023
    Contributor

    We CPed a revert. Closing.

  9. luacmartins
    closed this as completedon Nov 24, 2023
  10. luacmartins
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 24, 2023
  11. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    HourlyKSv2
    on Nov 27, 2023
  12. melvin-bot
    changed the title [-]Desktop - LHN is not updated on Member side after expense paid[/-] [+][HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid[/+] on Nov 27, 2023

  13. melvin-bot commented on Nov 27, 2023

    @melvin-bot
    melvin-botBot
    on Nov 27, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-04. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
  14. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Nov 29, 2023
  15. melvin-bot
    changed the title [-][HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid[/-] [+][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Desktop - LHN is not updated on Member side after expense paid[/+] on Nov 29, 2023

  16. melvin-bot commented on Nov 29, 2023

    @melvin-bot
    melvin-botBot
    on Nov 29, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions