Skip to content

[HOLD for payment 2024-02-07] [$500] Chat - "Hmm..page isn't here" briefly displayed after select business account #31836

Closed
Closed
[HOLD for payment 2024-02-07] [$500] Chat - "Hmm..page isn't here" briefly displayed after select business account#31836
Assignees
ntdiaryneil-marcellinikadiealexanderdukenv0307
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Nov 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30582

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create 2 accounts, one will be used as employee and second as an admin
  3. Request 1:1 money as employee from the admin
  4. Choose to pay with Business Bank account

Expected Result:

"Hmm..page isn't here" should not be displayed after select business account

Actual Result:

"Hmm..page isn't here" briefly displayed after select business account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (28)

Recording.5520.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f1c9cf0878a15b40
  • Upwork Job ID: 1731883805219770368
  • Last Price Increase: 2023-12-05
  • Automatic offers:
    • dukenv0307 | Contributor | 28012502
    • ntdiary | Contributor | 28065456
Issue OwnerCurrent Issue Owner: @michaelhaxhiu

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 24, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Nov 24, 2023
  3. melvin-bot
    assigned
    neil-marcellini
    on Nov 24, 2023

  4. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. crypto1014 commented on Nov 24, 2023

    @crypto1014
    crypto1014
    on Nov 24, 2023

    Hi

  6. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    📣 @devstar1014! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  7. crypto1014 commented on Nov 24, 2023

    @crypto1014
    crypto1014
    on Nov 24, 2023

    Contributor details
    Your Expensify account email: manoyomupro@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

  8. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    ⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

  9. crypto1014 commented on Nov 24, 2023

    @crypto1014
    crypto1014
    on Nov 24, 2023

    Contributor details
    Your Expensify account email: manoyomupro@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

  10. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  11. crypto1014 commented on Nov 24, 2023

    @crypto1014
    crypto1014
    on Nov 24, 2023

    Contributor details
    Your Expensify account email: manoyomupro@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~014b4c2f5c016b08c8

  12. melvin-bot commented on Nov 24, 2023

    @melvin-bot
    melvin-botBot
    on Nov 24, 2023 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  13. luacmartins commented on Nov 24, 2023

    @luacmartins
    luacmartins
    on Nov 24, 2023
    Contributor

    This happens when we navigate before the optimistic data created in CreateWorkspaceFromIOUPayment is available in Onyx. Using Onyx.set instead of merge of optimisticData seems to solve the issue.

    Given this is a small issue that doesn't affect functionality and the solution above might be controversial, I'm gonna demote this to NAB so we can land on a proper solution.

  14. luacmartins
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 24, 2023

  15. 70 remaining items

  16. kadiealexander
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 1, 2024
  17. kadiealexander
    unassigned
    michaelhaxhiu
    on Feb 1, 2024
  18. melvin-bot
    assigned
    kadiealexander
    on Feb 1, 2024

  19. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botBot
    on Feb 1, 2024 – with Melvin Bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  20. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Feb 1, 2024

  21. kadiealexander commented on Feb 2, 2024

    @kadiealexander
    kadiealexander
    on Feb 2, 2024
    Contributor

    Payment issued for @dukenv0307. @ntdiary please don't forget the checklist!

  22. ntdiary commented on Feb 2, 2024

    @ntdiary
    ntdiary
    on Feb 2, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1475531063
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
    • [@ntdiary] Determine if we should create a regression test for this bug. Yes
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Done
    • [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

    I think it's good to create a regression test. Because in the future, we might still optimize the logic here in some better ways, and both this issue and #35366 are related to the same business process. Regression test can help ensure that the bug doesn't occur again. :)

    Regression test steps:

    1. Prepare two accounts userA and userB.
    2. Request 1:1 money as userA from userB.
    3. As userB, choose to Pay with Expensify and select Business bank account.
    4. Verify that "Hmm..it's not here" page doesn't briefly (or persistently) display.
  23. melvin-bot
    added
    Overdue
    on Feb 5, 2024

  24. melvin-bot commented on Feb 5, 2024

    @melvin-bot
    melvin-botBot
    on Feb 5, 2024 – with Melvin Bot

    @ntdiary, @neil-marcellini, @kadiealexander, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  25. melvin-bot
    added
    DailyKSv2
    and removed
    DailyKSv2
    Overdue
    on Feb 6, 2024

  26. kadiealexander commented on Feb 7, 2024

    @kadiealexander
    kadiealexander
    on Feb 7, 2024
    Contributor

    Payouts due:

    Upwork job is here.

  27. kadiealexander
    closed this as completedon Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions