You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace #31814
Version Number: 1.4.3-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Pre-requisite: user must be logged in, have created a workspace and invited user B to it.
As user A, go to LHN and wait there.
As user B, request money to the workspace owned by user A.
Verify user A.
Expected Result:
There should be no errors on the user A side after receiving a money request on the workspace.
Actual Result:
The app crashes when money request is received on the workspace.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]LHN - App crashes when money request is received on owned workspace[/-][+][$500] LHN - App crashes when money request is received on owned workspace[/+]on Nov 24, 2023
changed the title [-][$500] LHN - App crashes when money request is received on owned workspace[/-][+][HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/+]on Nov 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/-][+][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/+]on Nov 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hoangzinh] Determine if we should create a regression test for this bug.
[@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]LHN - App crashes when money request is received on owned workspace[/-][+][$500] LHN - App crashes when money request is received on owned workspace[/+]melvin-bot commentedon Nov 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0101b533aef941ae82
melvin-bot commentedon Nov 24, 2023
Triggered auto assignment to @peterdbarkerUK (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Nov 24, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)14 remaining items
luacmartins commentedon Nov 24, 2023
Closing since this is a dupe.
melvin-bot commentedon Nov 24, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$500] LHN - App crashes when money request is received on owned workspace[/-][+][HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/+]melvin-bot commentedon Nov 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/-][+][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] [$500] LHN - App crashes when money request is received on owned workspace[/+]melvin-bot commentedon Nov 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: