Repository navigation
[$500] Scan - Unable to proceed with Scan request using a CSV file #31811
Description
Activity
- addedExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorDailyKSv2KSv2BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.
on Nov 24, 2023 - changed the title
[-]Scan - Unable to proceed with Scan request using a CSV file[/-][+][$500] Scan - Unable to proceed with Scan request using a CSV file[/+]on Nov 24, 2023 Job added to Upwork: https://www.upwork.com/jobs/~014c65653fce87c138
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.- addedHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors
on Nov 24, 2023 Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
Scan - Unable to proceed with Scan request using a CSV file
What is the root cause of that problem?
We don't allow uploading csv file
What changes do you think we should make in order to solve the problem?
add csv file to ALLOWED_RECEIPT_EXTENSIONS CONST
We also need to update BE side to allow uploading CSV fileWhat alternative solutions did you explore? (Optional)
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to create a scan IOU request using a csv file
What is the root cause of that problem?
We don't allow csv file types now
Line 55 in a2fc32b
ALLOWED_RECEIPT_EXTENSIONS: ['jpg', 'jpeg', 'gif', 'png', 'pdf', 'htm', 'html', 'text', 'rtf', 'doc', 'tif', 'tiff', 'msword', 'zip', 'xml', 'message'], What changes do you think we should make in order to solve the problem?
I think we need to list all allowed file types here
Except csv, I think we can adddocx,xlsx,xls,tar,gz,eml,md, etcNote: Backend fix might be needed
What alternative solutions did you explore? (Optional)
We can close this as not bug. This is already aligned with backend validation - #29960 (comment)
Reacted by Błażej Kustra, Mohammad Luthfi Fathur Rahman and Ishpaul Singh@NicMendonca, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR: #29790
Version Number: v1.4.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Expected Result:
User is able to create a Scan request with a CSV file.
Actual Result:
User is unable to create a Scan request with a CSV file. It shows error 'This filetype is not allowed'.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6289088_1700788783509.bandicam_2023-11-24_01-36-22-748.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit