Skip to content

Chat - “Paste and Match Style”, “Paste as plain text”, Shift+Option+Cmd+V doesn't remove markdown #31805

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com or open Desktop App
  2. Login with any account
  3. Open any chat
  4. Copy message with markdown
  5. Paste it using “Paste and Match Style”, “Paste as plain text” for Desktop or Shift+Option+Cmd+V for Web

Expected Result:

Copied message pasted with markdown removed

Actual Result:

“Paste and Match Style”, “Paste as plain text”, Shift+Option+Cmd+V doesn't remove markdown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6289021_1700780332583.Desktop-Paste-Match-Plain-not-Work.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 23, 2023
  2. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Nov 23, 2023

    @melvin-bot

    Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    Probably coming from #31619

  6. FitseTLT commented on Nov 24, 2023

    @FitseTLT
    Contributor

    Probably coming from #31619

    Yeah, confirmed.
    So @robertKozik @flodnv it looks like the simple fix of setting markdown on the plain text of the clipboard doesn't work so I have got two options:

    1. To make only PrivateNote (a module) handle code paste by sharing same code used in Compose.
    2. Make kind of TextInput module (or update the already exiting one) that handle code paste (html) that will be shared everywhere we use a text input that should have code paste feature.
  7. flodnv commented on Nov 24, 2023

    @flodnv
    Contributor

    Honestly I don't know what's best, maybe for now we just revert that PR

  8. luacmartins commented on Nov 24, 2023

    @luacmartins
    Contributor

    Agreed. Revert PR here - #31852

  9. luacmartins commented on Nov 27, 2023

    @luacmartins
    Contributor

    We reverted this PR and the issue is no longer reproducible. Closing this issue in favor of the original one - #29806

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions