[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Login with HT account - applausetester+mnchat1@applause.expensifail.com

Expected Result:

Verify the UI has a loading "skeleton" state (offline avatar and placeholder lines) and loads after a few moments and the loading state is not visible anymore

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6288979_1700775441466.Recording__256.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01eec53be34df7522e
Upwork Job ID: 1735048003260628992
Last Price Increase: 2023-12-13

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@aldo-expensify

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv

@kbecciv do you have any crash log or console error?

@aldo-expensify

I suspect it might be coming from this PR - #31711. Gonna try to help @aldo-expensify reproduce this issue first

Hmm actually, I'm seeing the crash log below without a HT account

@quinthar

Seems like what @quinthar reported here

Seems to come from this line

App/src/libs/OptionsListUtils.js

Line 396 in 1163dc3

const actorID = report.managerID || reportAction.actorAccountID;

#31061 is candidate

Yea, I'm trying to reproduce in dev

Seems to come from this line

App/src/libs/OptionsListUtils.js

Line 396 in 1163dc3

const actorID = report.managerID || reportAction.actorAccountID;

For this to happen, we would need to fail to find the IOU here

App/src/libs/OptionsListUtils.js

Lines 425 to 431 in 36105a3

    
           const lastIOUMoneyReport = _.find( 
        
               allSortedReportActions[iouReport.reportID], 
        
               (reportAction, key) => 
        
                   ReportActionUtils.shouldReportActionBeVisible(reportAction, key) && 
        
                   reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && 
        
                   ReportActionUtils.isMoneyRequestAction(reportAction), 
        
           );

Job added to Upwork: https://www.upwork.com/jobs/~01eec53be34df7522e

@allroundexperts

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

@allroundexperts

Contributor+: @allroundexperts owed $500 via NewDot

@allroundexperts

@allroundexperts can you complete the BZ checklist? Thx

Checklist

This bug was caused by fix: fix lhn previews #31061. The author is aware of this bug.
N/A
N/A
I think a regression test is not needed here because this involved a crash after just logging in to an account. This should be already covered in prior test cases.

@allroundexperts

$500 payment approved for @allroundexperts based on summary above.

@allroundexperts

@allroundexperts, @muttmuure, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@allroundexperts

@allroundexperts did you receive your payment?

This should all be wrapped up, so closing. Reply if you disagree!

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

68 remaining items

Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const lastIOUMoneyReport = _.find(
	allSortedReportActions[iouReport.reportID],
	(reportAction, key) =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);

[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

situchan commented on Nov 23, 2023

luacmartins commented on Nov 23, 2023

luacmartins commented on Nov 23, 2023

situchan commented on Nov 23, 2023

luacmartins commented on Nov 23, 2023

situchan commented on Nov 23, 2023

luacmartins commented on Nov 23, 2023

aldo-expensify commented on Nov 23, 2023

68 remaining items

melvin-bot commented on Dec 13, 2023

melvin-bot commented on Dec 13, 2023

mallenexpensify commented on Dec 13, 2023

mallenexpensify commented on Dec 13, 2023

allroundexperts commented on Dec 14, 2023

Checklist

JmillsExpensify commented on Dec 14, 2023

melvin-bot commented on Dec 18, 2023

aldo-expensify commented on Dec 18, 2023

mallenexpensify commented on Dec 19, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions