[WAITING ON CHECKLIST] [$500] Bank account - App crashes when tapping on Fix the errors in Connect BA page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Launch New Expensify app.
Go to Settings > Workspaces > any workspace.
Click Bank account.
Click Connect manually.
Enter both bank account numbers.
Without checking the ToS checkbox, tap Continue.
Tap Fix the errors.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6288914_1700770188377.Screen_Recording_20231124_035640_One_UI_Home.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0127dd2a89d454700f
Upwork Job ID: 1727796833108000768
Last Price Increase: 2023-12-08

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Li357

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when tapping on Fix the errors while checkbox is not checked

What is the root cause of that problem?

wrong forwardedRef prop key here

App/src/components/CheckboxWithLabel.js

Line 109 in 7a68a3d

forwardedRef={props.forwardedRef}

This is regression from #31369
Before this PR, Checkbox used props.forwardedRef
After this PR, no longer using props.forwardedRef but instead use ref

So it causes focusInput null in FormWrapper:

App/src/components/Form/FormWrapper.js

Lines 127 to 130 in 7a68a3d

    
           const focusInput = inputRefs.current[focusKey].current; 
        
           // Dismiss the keyboard for non-text fields by checking if the component has the isFocused method, as only TextInput has this method. 
        
           if (typeof focusInput.isFocused !== 'function') {

What changes do you think we should make in order to solve the problem?

replace above line with ref={props.forwardedRef}

@mkhutornyi

@mkhutornyi RCA seems correct, but I think we should rename the prop passed down to ref, since that's what we've been doing for TS migrations. Are you available to work on a fix PR within the next hour?

yes I am

@burczu

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu] The PR that introduced the bug has been identified. Link to the PR: [TS Migration] Migrate Checkbox.js to TypeScript #31369
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [TS Migration] Migrate Checkbox.js to TypeScript #31369 (comment)
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@burczu] Determine if we should create a regression test for this bug. N/A
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@burczu

Not overdue but bump for @burczu to complete the checklist

@mkhutornyi

Payment Summary:

Contributor: @mkhutornyi $500 - I can't find you on Upworks, can you apply for the job?
C+: @burczu (invoiced payment) - Please complete checklist!

Upworks job

@jliexpensify

@jliexpensify applied. thank you

@mkhutornyi

Paid @mkhutornyi and removed job. Just waiting on checklist now.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

I completed the checklist. We're good to close. Thanks everyone!

Navigation Menu

Repository navigation

[WAITING ON CHECKLIST] [$500] Bank account - App crashes when tapping on Fix the errors in Connect BA page #31795

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

26 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const focusInput = inputRefs.current[focusKey].current;

	// Dismiss the keyboard for non-text fields by checking if the component has the isFocused method, as only TextInput has this method.
	if (typeof focusInput.isFocused !== 'function') {

[WAITING ON CHECKLIST] [$500] Bank account - App crashes when tapping on Fix the errors in Connect BA page #31795

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

melvin-bot commented on Nov 23, 2023

mkhutornyi commented on Nov 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

luacmartins commented on Nov 23, 2023

mkhutornyi commented on Nov 23, 2023

26 remaining items

melvin-bot commented on Nov 29, 2023

jliexpensify commented on Dec 6, 2023

jliexpensify commented on Dec 8, 2023

mkhutornyi commented on Dec 8, 2023

jliexpensify commented on Dec 8, 2023

melvin-bot commented on Dec 8, 2023

luacmartins commented on Dec 8, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions