Skip to content

[HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users #31792

Closed
Closed
[HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users#31792
Assignees
s77rtluacmartinszanyrenneydukenv0307
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Nov 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create group conversation with users you have not existing conversation before
  3. Click on "+" button from chat composer> Split Bill
  4. Add amount and click Next button

Expected Result:

User should be able to create Split bill with "Hidden" users, Split button should be active

Actual Result:

User is not able to create IOU with "Hidden" users, Split button is grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6288856_1700766588471.Recording__1401.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b1b3071c11ee0d1c
  • Upwork Job ID: 1727789932415844352
  • Last Price Increase: 2023-11-23
  • Automatic offers:
    • s77rt | Reviewer | 27867123
    • dukenv0307 | Contributor | 27867124

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 23, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Nov 23, 2023

  3. github-actions commented on Nov 23, 2023

    @github-actions
    github-actionsBot
    on Nov 23, 2023 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  4. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot

    📣 @github-actions[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
  5. melvin-bot
    assigned
    luacmartins
    on Nov 23, 2023

  6. melvin-bot commented on Nov 23, 2023

    @melvin-bot
    melvin-botBot
    on Nov 23, 2023 – with Melvin Bot

    Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    Investigating. Might be intended.

  8. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    Ok, I don't think this is intended because we can still split bill with anon users from the global create

  9. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    This issue also happens in prod. Not a blocker. I think this PR introduced the issue because we filter participants without a login here so the participant list is empty

  10. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    Reproducible on production:

    prod.mov
  11. luacmartins
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Nov 23, 2023

  12. luacmartins commented on Nov 23, 2023

    @luacmartins
    luacmartins
    on Nov 23, 2023
    Contributor

    cc @lukemorawski @puneetlath @allroundexperts

  13. 27 remaining items

  14. dukenv0307 commented on Nov 29, 2023

    @dukenv0307
    dukenv0307
    on Nov 29, 2023
    Contributor

    @s77rt The PR is ready for review.

  15. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Dec 5, 2023
  16. melvin-bot
    changed the title [-][$500] IOU - Unable to create IOU with "Hidden" users[/-] [+][HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users[/+] on Dec 5, 2023
  17. melvin-bot
    removed
    ReviewingHas a PR in review
    on Dec 5, 2023

  18. melvin-bot commented on Dec 5, 2023

    @melvin-bot
    melvin-botBot
    on Dec 5, 2023 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. melvin-bot commented on Dec 5, 2023

    @melvin-bot
    melvin-botBot
    on Dec 5, 2023 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  20. melvin-bot commented on Dec 5, 2023

    @melvin-bot
    melvin-botBot
    on Dec 5, 2023 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  21. s77rt commented on Dec 5, 2023

    @s77rt
    s77rt
    on Dec 5, 2023
    Member

    Regression Test Proposal

    1. Start a chat with a user you have not chatted with before
    2. Verify the user's display name is "Hidden"
    3. Start money request flow (press the + grey button)
    4. Verify you were able to complete the money request
  22. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Dec 11, 2023

  23. zanyrenney commented on Dec 13, 2023

    @zanyrenney
    zanyrenney
    on Dec 13, 2023
    Contributor

    payment summary

    no bug finder - applause
    @s77rt requires payment offer (Reviewer) - paid $500
    @dukenv0307 requires payment offer (Contributor) - paid $500

  24. zanyrenney commented on Dec 13, 2023

    @zanyrenney
    zanyrenney
    on Dec 13, 2023
    Contributor

    regression test can be worked on separately, all payments complete - closing!

  25. zanyrenney
    closed this as completedon Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions