[Awaiting Payment - 22nd Dec] [$500] User Account Swapping Issue in IOU When Splitting Bills

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Navigate to FAB
2, Select "Request Money."
3, Enter the desired amount
4, Add the recipient's email
5, Enable the "Add Split" option

Expected Result:

The user profile should not be swapped

Actual Result:

The user profile is swapped when splitting a bill in IOU between two users

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6287208_1700660684896.swapped.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d923d8de5457372f
Upwork Job ID: 1727385176024190976
Last Price Increase: 2023-11-29
Automatic offers:

s-alves10 | Contributor | 27935989

Job added to Upwork: https://www.upwork.com/jobs/~01d923d8de5457372f

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

cannot reproduce it on the latest main

Proposal

Please re-state the problem that we are trying to solve in this issue.

User avatars are swapped in IOU preview when splitting bills

What is the root cause of that problem?

When splitting a bill, users are added in order they are selected. In that order, they are displayed in MoneyRequestPreview. But the SplitBillAndOpenReport API returns sorted particiapantAccountIDs as you can see below

This is the root cause

What changes do you think we should make in order to solve the problem?

We can show the participants avatars sorted by its accountID or name(login) In MoneyRequestPreview
Update

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 154 in 4952c39

    
           const participantAvatars = OptionsListUtils.getAvatarsForAccountIDs(participantAccountIDs, props.personalDetails);

to

    const participantAvatars = OptionsListUtils.getAvatarsForAccountIDs(participantAccountIDs, props.personalDetails);
    const sortedParticipantAvatars = _.sortBy(participantAvatars, (avatar) => avatar.name);
    // const sortedParticipantAvatars = _.sortBy(participantAvatars, (avatar) => avatar.id);

And use sortedParticipantAvatars instead of participantAvatars

Result

31732.mp4

What alternative solutions did you explore? (Optional)

Very interesting! It's pretty minor, but I agree it's a little jarring to see the switch around because of the default avatars changing completely. Is it not possible to keep the same selected order on the split preview?

@trjExpensify

Very interesting! It's pretty minor, but I agree it's a little jarring to see the switch around because of the default avatars changing completely. Is it not possible to keep the same selected order on the split preview?

@trjExpensify It's definitely possible but we'll need to change this from the backend then. I think its better to standardise this by sorting the results. As such, what @s-alves10 proposed above looks like a better solution IMO.

@allroundexperts

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@allroundexperts

@allroundexperts

PR is ready for review #32419

@robertjchen

Pay date here would be 22 Dec @robertjchen

Checklist

Continue personalDetails -> personalDetailsList migration #20328
https://github.com/Expensify/App/pull/20328/files#r1431287393
N/A
A regression test would be helpful.

Regression test

Click on the FAB -> Request Money -> Enter amount & recipient -> Submit
On the screen that opens, observe the IOU preview message.

Verify that the order of avatars in the preview message does not change.

Do we 👍 or 👎 ?

@allroundexperts

As this was caught by Applause in the regression testing and there's one to cover this flow, I don't think we need a new dedicated one for it personally.

Updating the title to note the 22nd as the payment date. Confirming those payments will be:

$500 to @allroundexperts for the C+ review
$500 to @s-alves10 for the fix - paid

@allroundexperts

👋 @allroundexperts have you requested for this one?

Requested. Feel free to close!

Thanks!

@allroundexperts

$500 payment to @allroundexperts based on this comment.

Navigation Menu

Repository navigation

[Awaiting Payment - 22nd Dec] [$500] User Account Swapping Issue in IOU When Splitting Bills #31732

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

12 remaining items

Checklist

Regression test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Awaiting Payment - 22nd Dec] [$500] User Account Swapping Issue in IOU When Splitting Bills #31732

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 22, 2023

melvin-bot commented on Nov 22, 2023

melvin-bot commented on Nov 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 22, 2023

abzokhattab commented on Nov 22, 2023

dummy-1111 commented on Nov 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

trjExpensify commented on Nov 23, 2023

allroundexperts commented on Nov 26, 2023

12 remaining items

melvin-bot commented on Dec 3, 2023

melvin-bot commented on Dec 3, 2023

dummy-1111 commented on Dec 3, 2023

dummy-1111 commented on Dec 15, 2023

allroundexperts commented on Dec 19, 2023

Checklist

Regression test

trjExpensify commented on Dec 19, 2023

trjExpensify commented on Jan 9, 2024

allroundexperts commented on Jan 9, 2024

robertjchen commented on Jan 9, 2024

JmillsExpensify commented on Jan 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions