Skip to content

[HOLD for payment 2023-12-18] [$125] [Form Provider Refactor] ValidationStep #31565

Closed

Description

@luacmartins

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/ValidationStep.js

cc @kowczarz @cdOut

Note: this component also needs to be migrated to a functional component!

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ade963fcc59d6b1b
  • Upwork Job ID: 1726652711149305856
  • Last Price Increase: 2023-11-28
Issue OwnerCurrent Issue Owner: @kowczarz

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2023
  2. self-assigned this
    on Nov 20, 2023
  3. melvin-bot commented on Nov 20, 2023

    @melvin-bot
  4. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. melvin-bot commented on Nov 20, 2023

    @melvin-bot
  6. melvin-bot commented on Nov 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @alitoshmatov (Internal)

  7. luacmartins commented on Nov 22, 2023

    @luacmartins
    ContributorAuthor

    @cdOut @kowczarz are either of you available to work on this one?

  8. luacmartins commented on Nov 27, 2023

    @luacmartins
    ContributorAuthor
  9. kowczarz commented on Nov 28, 2023

    @kowczarz
    Contributor

    Yes, I would like to work on this task.

  10. 17 remaining items

  11. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Dec 11, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.10-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-18. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Dec 11, 2023

    @melvin-bot
  14. puneetlath commented on Dec 13, 2023

    @puneetlath
    Contributor
  15. alitoshmatov commented on Dec 13, 2023

    @alitoshmatov
    Contributor

    Accepted

  16. puneetlath commented on Dec 18, 2023

    @puneetlath
    Contributor

    Paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions