[HOLD for payment 2023-12-07] [$500] Request money get $250 not formatted correctly

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.0-3
Reproducible in staging?: y
Reproducible in production?: seems new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700345578210519

Action Performed:

1. Click on the + fab
2. Request money
3. Enter an amount and go to the participants selection step
4. Click on the Request money, get $250 bottom alert.

Expected Result:

Request money, get $250 text to be formatted correctly.

Actual Result:

Incorrect formatting (includes an extra space before the amount)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.246.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6c623a72781c0f8
• Upwork Job ID: 1726615300061036544
• Last Price Increase: 2023-11-27
• Automatic offers:
• fedirjh | Reviewer | 27852593

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f6c623a72781c0f8

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[m-natarajan]

Proposal from @allroundexperts

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 not formatted correctly.

What is the root cause of that problem?

We have added an extra space here

What changes do you think we should make in order to solve the problem?

Just remove the extra space here.

What alternative solutions did you explore? (Optional)

None

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 not formatted correctly.

Root cause

We have extra space here:

App/src/languages/en.ts

Line 1923 in aeced9a

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

Changes

We need to remove the space

App/src/languages/en.ts

Line 1923 in aeced9a

body: `Request money from a new Expensify account. Get $${CONST.REFERRAL_PROGRAM.REVENUE} once they start an annual subscription with two or more active members and make the first two payments toward their Expensify bill.`,

[situchan]

This should be handled as follow-up of #30372
cc: @waterim @cubuspl42 @puneetlath

[yatinj30]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money, get $250 is not formatted correctly.

What is the root cause of that problem?

There is an extra space before an amount.

What changes do you think we should make in order to solve the problem?

Remove that extra space before an amount.

What alternative solutions did you explore? (Optional)

None